adding a check to bootstrap script #36256
Conversation
and a check to the rust config script
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the PR! The |
|
Yeah, I didn't make it as far as actually make it do something yet. I was reading through the bootstrap readme and was probably ask for some guidance but thanks for the advance advice. :) |
|
I don't have a solid grasp on how all the build system pieces work these days, but I expected this detection to happin in |
|
Dang, ok. I was a bit off. I think I focused on /src/bootstrap too much and will look at configure more. |
a nodejs cmd sanity check
|
So I think I made a bit of progress. I am now detecting nodejs back in I get a bit lost after this. Where to pass it next or how to add a test to compiletest for it or if I need to? Any advice on where to look next? Thanks in advance! :) |
| // If a manual nodejs was added to the config, | ||
| // of if a nodejs install is detected through config, use it. | ||
| if build.config.nodejs.is_some() { | ||
| need_cmd("nodejs".as_ref()) |
There was a problem hiding this comment.
Here I think you'll want to do:
if let Some(ref s) = build.config.nodejs {
need_cmd(s.as_ref());
}
|
⌛ Testing commit 89bc13c with merge 48dd4f4... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry On Fri, Sep 9, 2016 at 12:40 PM, bors notifications@github.com wrote:
|
…207, r=alexcrichton adding a check to bootstrap script and a check to the rust config script refs #36207 first crack at making configure detect nodejs
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry On Fri, Sep 9, 2016 at 3:27 PM, bors notifications@github.com wrote:
|
and a check to the rust config script
refs #36207
first crack at making configure detect nodejs