Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unmarked_api feature. #37981

Closed
eddyb opened this issue Nov 24, 2016 · 0 comments
Closed

Remove the unmarked_api feature. #37981

eddyb opened this issue Nov 24, 2016 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@eddyb
Copy link
Member

eddyb commented Nov 24, 2016

According to #22820 and @petrochenkov in #37676 (comment), this feature-gate should not be used.
It appears that earlier error checking in the compiler prevents it from ever mattering anyway.
@eddyb eddyb added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Nov 24, 2016
@eddyb eddyb mentioned this issue Nov 24, 2016
Merged
@jooert jooert mentioned this issue Nov 30, 2016
Merged
jooert added a commit to jooert/rust that referenced this issue Nov 30, 2016
@jooert
Remove the unmarked_api feature
7cbd18a 
Closes rust-lang#37981.
bors added a commit that referenced this issue Dec 4, 2016
@bors
Auto merge of #38087 - jooert:remove_unmarked, r=petrochenkov
341f084 
Remove the `unmarked_api` feature

Closes #37981.
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@jooert @Manishearth
Remove the unmarked_api feature
9a1ece6 
Closes rust-lang#37981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddyb