Remove the unmarked_api feature
#38087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
| .emit() | ||
| } | ||
| span_bug!(span, "Encountered unmarked API, which should \ | ||
| not exist in the standard library"); |
There was a problem hiding this comment.
Encountering unmarked API is not a library's fault, but a compiler bug. Could you tweak the message to not mention the standard library, e.g. just "encountered unmarked API".
|
r=me with tweaked message |
jooert
force-pushed
the
remove_unmarked
branch
from
8623d55 to
7cbd18a
Compare
|
Sure, I have changed it to what you proposed. |
|
@bors r+ |
|
📌 Commit 7cbd18a has been approved by |
bors
added a commit
that referenced
this pull request
Dec 4, 2016
Remove the `unmarked_api` feature Closes #37981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37981.