Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc no longer shows trait implementations in the documentation #5406

Closed
thestinger opened this issue Mar 16, 2013 · 1 comment
Closed

rustdoc no longer shows trait implementations in the documentation #5406

thestinger opened this issue Mar 16, 2013 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
0.6

Comments

@thestinger
Copy link
Contributor

This was caused by 387aa36 - rustdoc has an is_visible function that checks to see if items have ast::public visibility and trait implementations don't. It needs to check if something is a trait implementation, and if so make it visible if the trait is public.

Example: http://static.rust-lang.org/doc/std/treemap.html (no Map or Set impl shown)
brson added a commit to brson/rust that referenced this issue Mar 16, 2013
@brson
rustdoc: Show all impls of traits. rust-lang#5406
deeeaf0
@thestinger
Copy link
Contributor Author

Fixed by deeeaf0, which shows all trait implementations. Opened #5416 to replace this.

oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@flip1995
Rollup merge of rust-lang#5406 - flip1995:update_lints_fix, r=flip1995
46337cb 
Fix update_lints

This fixes a bug in update_lints, where `internal` lints were not registered properly. This also cleans up some code. For example: The code generation functions no longer filter the lints the are given. This is now the task of the caller. This way, it is more obvious in the `replace_in_file` calls which lints will be included in which part of a file.

This also turns the lint modules private. There is no need for them to be public, since shared code should be in the utils module anyway.

And last but not least, this fixes the `register_lints` code generation, so also internal lints get registered.

changelog: none
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5438 - flip1995:rollup-pi762oy, r=flip1995
f8308c8 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#5406 (Fix update_lints)
 - rust-lang#5409 (Downgrade let_unit_value to pedantic)
 - rust-lang#5410 (Downgrade trivially_copy_pass_by_ref to pedantic)
 - rust-lang#5412 (Downgrade inefficient_to_string to pedantic)
 - rust-lang#5415 (Add new lint for `Result<T, E>.map_or(None, Some(T))`)
 - rust-lang#5417 (Update doc links and mentioned names in docs)
 - rust-lang#5419 (Downgrade unreadable_literal to pedantic)
 - rust-lang#5420 (Downgrade new_ret_no_self to pedantic)
 - rust-lang#5422 (CONTRIBUTING.md: fix broken triage link)
 - rust-lang#5424 (Incorrect suspicious_op_assign_impl)
 - rust-lang#5425 (Ehance opt_as_ref_deref lint.)

Failed merges:

 - rust-lang#5345 (Add lint for float in array comparison)
 - rust-lang#5411 (Downgrade implicit_hasher to pedantic)
 - rust-lang#5428 (Move cognitive_complexity to nursery)

r? @ghost

changelog: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@thestinger