Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#63658 #63673

Closed
rust-highfive opened this issue Aug 17, 2019 · 1 comment · Fixed by #63747
Closed

miri no longer builds after rust-lang/rust#63658 #63673

rust-highfive opened this issue Aug 17, 2019 · 1 comment · Fixed by #63747
Assignees
@eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #63658, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @RalfJung, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 17, 2019
@RalfJung
Copy link
Member

Miri fix at rust-lang/miri#911

@RalfJung RalfJung mentioned this issue Aug 20, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Aug 20, 2019
@Centril
Rollup merge of rust-lang#63747 - RalfJung:miri, r=RalfJung
e768218 
update Miri

Fixes rust-lang#63673

r? @oli-obk
@bors bors closed this as completed in ddb6314 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Miri RalfJung/rust
4 participants
@eddyb @RalfJung @oli-obk @rust-highfive