Skip to content

Refactor Miri ops (unary, binary) to have more types #63658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2019
Merged

Refactor Miri ops (unary, binary) to have more types #63658

merged 3 commits into from
Aug 17, 2019

Conversation

RalfJung
Copy link
Member

This is the part of #63448 that is just a refactoring. It helps that PR by making it easier to perform machine arithmetic.

r? @oli-obk @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2019
@RalfJung RalfJung mentioned this pull request Aug 17, 2019
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Aug 17, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 17, 2019

📌 Commit 5ac2045 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2019
@bors
Copy link
Collaborator

bors commented Aug 17, 2019

⌛ Testing commit 5ac2045 with merge 2111aed...

bors added a commit that referenced this pull request Aug 17, 2019
@bors
Auto merge of #63658 - RalfJung:miri-op, r=oli-obk
2111aed 
Refactor Miri ops (unary, binary) to have more types

This is the part of #63448 that is just a refactoring. It helps that PR by making it easier to perform machine arithmetic.

r? @oli-obk @eddyb
@bors
Copy link
Collaborator

bors commented Aug 17, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 2111aed to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2019
@bors bors merged commit 5ac2045 into rust-lang:master Aug 17, 2019
@rust-highfive rust-highfive mentioned this pull request Aug 17, 2019
Closed
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #63658!

Tested on commit 2111aed.
Direct link to PR: #63658

💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 17, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#63658!
0d2bfae 
Tested on commit rust-lang/rust@2111aed.
Direct link to PR: <rust-lang/rust#63658>

💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
@RalfJung RalfJung deleted the miri-op branch August 18, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @oli-obk @bors @rust-highfive