Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build rust with rustpkg #6406

Closed
catamorphism opened this issue May 10, 2013 · 1 comment
Closed

Build rust with rustpkg #6406

catamorphism opened this issue May 10, 2013 · 1 comment

Comments

@catamorphism
Copy link
Contributor

Build rustc with rustpkg, get rid of Makefiles. As an incremental step, we could build some of the "additional" packages like libstd (soon to be renamed) with rustpkg and keep the Makefiles for rustc itself.
@ghost ghost assigned catamorphism May 10, 2013
@catamorphism
Copy link
Contributor Author

on second thought, I'll just modify #2237

@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 27, 2022
@bors
Auto merge of rust-lang#8271 - Jarcho:ptr_arg_214, r=flip1995
4992548 
Check usages in `ptr_arg`

fixes rust-lang#214
fixes rust-lang#1981
fixes rust-lang#3381
fixes rust-lang#6406
fixes rust-lang#6964

This does not take into account the return type of the function currently, so `(&Vec<_>) -> &Vec<_>` functions may still be false positives.

The name given for the type also has to match the real type name, so `type Foo = Vec<u32>` won't trigger the lint, but `type Vec = Vec<u32>` will. I'm not sure if this is the best way to handle this, or if a note about the actual type should be added instead.

changelog: Check if the argument is used in a way which requires the original type in `ptr_arg`
changelog: Lint mutable references in `ptr_arg`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catamorphism