std: add an external iterator for mutating vec elements #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Jun 6, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2022
Check usages in `ptr_arg` fixes rust-lang#214 fixes rust-lang#1981 fixes rust-lang#3381 fixes rust-lang#6406 fixes rust-lang#6964 This does not take into account the return type of the function currently, so `(&Vec<_>) -> &Vec<_>` functions may still be false positives. The name given for the type also has to match the real type name, so `type Foo = Vec<u32>` won't trigger the lint, but `type Vec = Vec<u32>` will. I'm not sure if this is the best way to handle this, or if a note about the actual type should be added instead. changelog: Check if the argument is used in a way which requires the original type in `ptr_arg` changelog: Lint mutable references in `ptr_arg`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.