Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py test generates several dot files in the source directory root #65071

Closed
petrochenkov opened this issue Oct 3, 2019 · 1 comment · Fixed by #65073 or #65629
Closed

x.py test generates several dot files in the source directory root #65071

petrochenkov opened this issue Oct 3, 2019 · 1 comment · Fixed by #65073 or #65629
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@petrochenkov
Copy link
Contributor 

definite_init_indirect.dot
maybe_init_indirect.dot
maybe_uninit_indirect.dot
mut_borrowed_locals_indirect.dot

If they are necessary, then they should be generated somewhere inside the build directory.
cc @ecstatic-morse
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2019
@ecstatic-morse ecstatic-morse mentioned this issue Oct 3, 2019
Merged
@bors bors closed this as completed in aacc89a Oct 4, 2019
@petrochenkov
Copy link
Contributor Author

Repening, the dot files are generated again.

borrows_hello.dot
definite_init_hello.dot
ever_init_hello.dot
flow_has_mut_interior_hello.dot
flow_needs_drop_hello.dot
maybe_init_hello.dot
maybe_uninit_hello.dot
mut_borrowed_locals_hello.dot

@petrochenkov petrochenkov reopened this Oct 20, 2019
@ecstatic-morse ecstatic-morse mentioned this issue Oct 20, 2019
Merged
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this issue Oct 20, 2019
@ecstatic-morse
Check all files in src/test for borrowck_graphviz_postflow
c9e361f 
This attribute causes DOT files to be generated in the top-level
directory. It is intended to be used only temporarily and should never
appear on master.

This will prevent rust-lang#65071 from occurring again.
@ecstatic-morse ecstatic-morse mentioned this issue Oct 20, 2019
Merged
@bors bors closed this as completed in 041c654 Oct 21, 2019
bors added a commit that referenced this issue Oct 21, 2019
@bors
Auto merge of #65630 - ecstatic-morse:graphviz-tidy, r=Mark-Simulacrum
1ba7b4e 
Check all files in `src/test` for `borrowck_graphviz_postflow`

This attribute causes DOT files to be generated in the top-level directory. It is intended to be used only temporarily and should never appear on master. This also tells git to ignore DOT files in the root or the  `mir_dump` directory, which `-Z dump-mir` uses by default.

This will prevent #65071 from occurring again. It needs to be merged after #65629, otherwise `tidy` will start failing.

r? @Mark-Simulacrum
@RalfJung RalfJung mentioned this issue Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
2 participants
@jonas-schievink @petrochenkov