Remove borrowck_graphviz_postflow from test
#65629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
We should probably lint against this in tidy perhaps? Let's leave that for a future PR though @bors r+ for now |
|
📌 Commit 51a5b49 has been approved by |
bors
added
S-waiting-on-bors
|
Feels like the cleaner way to handle this is via |
|
The problem here isn't that the files are getting committed -- it is there existence that is the issue. gitignore does not help with their existence, only hides the problem. |
|
Doesn't feel like their existence is the problem tbh (although not adding junk to the git root is good); it feels like them dirtying up |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 20, 2019
…ark-Simulacrum Remove `borrowck_graphviz_postflow` from test Resolves rust-lang#65071 (again). Sorry. I've added a commit hook to prevent this from happening in the future. r? @petrochenkov
bors
added a commit
that referenced
this pull request
Oct 20, 2019
Rollup of 8 pull requests Successful merges: - #65314 (rustdoc: forward -Z options to rustc) - #65592 (clarify const_prop ICE protection comment) - #65603 (Avoid ICE when include! is used by stdin crate) - #65614 (Improve error message for APIT with explicit generic arguments) - #65629 (Remove `borrowck_graphviz_postflow` from test) - #65633 (Remove leading :: from paths in doc examples) - #65638 (Rename the default argument 'def' to 'default') - #65639 (Fix parameter name in documentation) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Oct 21, 2019
Check all files in `src/test` for `borrowck_graphviz_postflow` This attribute causes DOT files to be generated in the top-level directory. It is intended to be used only temporarily and should never appear on master. This also tells git to ignore DOT files in the root or the `mir_dump` directory, which `-Z dump-mir` uses by default. This will prevent #65071 from occurring again. It needs to be merged after #65629, otherwise `tidy` will start failing. r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #65071 (again).
Sorry. I've added a commit hook to prevent this from happening in the future.
r? @petrochenkov