Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ayu theme hover not noticible #75880

Closed
pickfire opened this issue Aug 24, 2020 · 3 comments · Fixed by #75901
Closed

Ayu theme hover not noticible #75880

pickfire opened this issue Aug 24, 2020 · 3 comments · Fixed by #75901
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pickfire
Copy link
Contributor

image

Note that "Ayu" is already highlighted, it happens to mdbook too.

CC @GuillaumeGomez
@pickfire pickfire added the C-bug Category: This is a bug. label Aug 24, 2020
@GuillaumeGomez
Copy link
Member

The contrast is too small indeed. Want to send a fix?

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed C-bug Category: This is a bug. labels Aug 24, 2020
@pickfire
Copy link
Contributor Author

I will pass on this, I sent too many pull requests today, I can do this maybe another day (a few days) or if anyone is interested can take up this task before I do.

@GuillaumeGomez
Copy link
Member

I'll certainly send a PR tomorrow then.

@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 25, 2020
Merged
@jyn514 jyn514 added the A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc label Aug 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 27, 2020
@Dylan-DPC
Rollup merge of rust-lang#75901 - GuillaumeGomez:ayu-theme-button-hov…
e187ea9 
…er-background-color, r=pickfire

Improve theme button hover background color

Fixes rust-lang#75880.

![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png)
![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png)

r? @pickfire
pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 28, 2020
@pietroalbini
Rollup merge of rust-lang#75901 - GuillaumeGomez:ayu-theme-button-hov…
a1b440f 
…er-background-color, r=pickfire

Improve theme button hover background color

Fixes rust-lang#75880.

![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png)
![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png)

r? @pickfire
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 29, 2020
@Dylan-DPC
Rollup merge of rust-lang#75901 - GuillaumeGomez:ayu-theme-button-hov…
2c06347 
…er-background-color, r=pickfire

Improve theme button hover background color

Fixes rust-lang#75880.

![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png)
![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png)

r? @pickfire
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 29, 2020
@Dylan-DPC
Rollup merge of rust-lang#75901 - GuillaumeGomez:ayu-theme-button-hov…
f9e7b3e 
…er-background-color, r=pickfire

Improve theme button hover background color

Fixes rust-lang#75880.

![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png)
![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png)

r? @pickfire
@bors bors closed this as completed in 99b4a01 Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve theme button hover background color GuillaumeGomez/rust
3 participants
@GuillaumeGomez @pickfire @jyn514