-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve theme button hover background color #75901
Improve theme button hover background color #75901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better but still not so visible.
Surprisingly it's quite visible when you're hovering and all. I prefer not to change the color too much for now though. Might be interesting to make another pass later on. @bors: r=pickfire rollup |
📌 Commit f20f7f2 has been approved by |
…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880. ![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png) ![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png) r? @pickfire
…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880. ![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png) ![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png) r? @pickfire
…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880. ![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png) ![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png) r? @pickfire
…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880. ![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png) ![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png) r? @pickfire
☀️ Test successful - checks-actions, checks-azure |
Fixes #75880.
r? @pickfire