-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #75999
Rollup of 10 pull requests #75999
Conversation
Fixes a false positive for transparent newtype with a non-zero member.
Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
Expand rustdoc theme chooser x padding ![image](https://user-images.githubusercontent.com/4687791/91057476-d0eea500-e659-11ea-8c9a-e44db937da89.png) ![image](https://user-images.githubusercontent.com/4687791/91057530-e368de80-e659-11ea-9298-fbb00006d91f.png) But I still think there is room for improvement considering mdbook. ![image](https://user-images.githubusercontent.com/4687791/91057583-f7acdb80-e659-11ea-9dc5-317caed92bc5.png) CC @GuillaumeGomez @jyn514
…declarations-transparent-nonzero, r=lcnr Fix another clashing_extern_declarations false positive. Fixes rust-lang#75739. Fix another clashing_extern_declarations false positive, this time for transparent newtype with a non-zero member. r? @lcnr
…_typo, r=petrochenkov Fix typo in TLS Model in Unstable Book
…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880. ![Screenshot from 2020-08-25 13-44-01](https://user-images.githubusercontent.com/3050060/91170922-e60b1880-e6d9-11ea-9eb1-61a44cdc28d9.png) ![Screenshot from 2020-08-25 13-43-43](https://user-images.githubusercontent.com/3050060/91170924-e73c4580-e6d9-11ea-969e-616bf4130975.png) r? @pickfire
Add test for issue rust-lang#27130 rust-lang#27130 seems to be fixed by the llvm 11 update. The issue is marked with needs-test, so here it is. As some historical context, the generated code was fine until 1.38, and remained unoptimized from 1.38 up until the current nightly. I've also added a pattern matching version that was fine on 1.45.2.
…, r=jyn514 Move to intra doc links for core::ptr::non_null Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc r? @jyn514
…r=ehuss Fix typo (`thumbv8m.main-none-eabihf` is Mainline)
Fix typo in release notes
Improve help popup Fixes rust-lang#75623. The second commit is just a slight improvement: the help popup won't be created until someone presses "?" or ESC. Not a big improvement in itself but considering the low amount of code required, I think it was worth the shot. r? @jyn514
Should not apply field accessing on enum Closes rust-lang#75977 But I'm surprised that `x.py test --stage 1` and CI didn't catch this with existing testcase. r? @estebank
@bors r+ rollup=never p=5 |
📌 Commit e23290f has been approved by |
⌛ Testing commit e23290f with merge f922f94dcb4092d91292eb86f66407f5f3e411c5... |
💔 Test failed - checks-actions |
How do you access the logs for the failed build? |
https://github.com/rust-lang-ci/rust/runs/1038546677 Looks like it's caused by #75910 :/ |
failed in rollup |
@bors r- |
@Dylan-DPC I think I fixed the issue, how should I proceed? |
i'll make a new rollup in a while |
Successful merges:
thumbv8m.main-none-eabihf
is Mainline) #75919 (Fix typo (thumbv8m.main-none-eabihf
is Mainline))Failed merges:
r? @ghost