Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#81250 #81341

Closed
rust-highfive opened this issue Jan 24, 2021 · 5 comments · Fixed by #81375
Closed

miri no longer builds after rust-lang/rust#81250 #81341

rust-highfive opened this issue Jan 24, 2021 · 5 comments · Fixed by #81375
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #81250, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @sivadeilra, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Jan 24, 2021
@RalfJung
Copy link
Member

Yeah I expected that PR to break Miri.^^ I'll look into it.

@sivadeilra
Copy link

I'll take a look.

@sivadeilra
Copy link

Is there a failed CI job that I can look at?

@RalfJung
Copy link
Member

Thanks for the offer! However, this will be much easier to do with some Miri experience, so in the interest of getting Miri to work again ASAP, it's probably better if I do it.

@sivadeilra
Copy link

Oh, certainly. I spent some time trying to learn how to get Miri building and running, which I have always wanted to do, anyway.

Here's my first attempt at fixing it:

sivadeilra/miri@d2ebf4b

Pretty obvious stuff, I guess.

@RalfJung RalfJung mentioned this issue Jan 25, 2021
@bors bors closed this as completed in 7fba12b Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants