Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #81375

Merged
merged 1 commit into from
Jan 25, 2021
Merged

update Miri #81375

merged 1 commit into from
Jan 25, 2021

Conversation

RalfJung
Copy link
Member

Fixes #81341
Cc @rust-lang/miri r? @ghost

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 25, 2021

📌 Commit 26e67ad has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 25, 2021
@bors
Copy link
Contributor

bors commented Jan 25, 2021

⌛ Testing commit 26e67ad with merge 2495ff4313b0c2255944eedc552df6a234a72faf...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    Checking crates-io v0.31.1 (/tmp/cargo/crates/crates-io)
error[E0283]: type annotations needed
   --> src/cargo/util/config/de.rs:530:63
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, env.as_ref()))
    |                                                           |   |
    |                                                           |   |
    |                                                           |   cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                                                           this method call resolves to `&T`
    |
    = note: cannot satisfy `std::string::String: AsRef<_>`
help: use the fully qualified path for the potential candidates
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<OsStr>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<std::path::Path>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<str>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<[u8]>>::as_ref(env)))

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.

@bors
Copy link
Contributor

bors commented Jan 25, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2021
@RalfJung
Copy link
Member Author

Wait, why did cargo fail to build??

2021-01-25T11:21:52.6405659Z error[E0283]: type annotations needed
2021-01-25T11:21:52.6409991Z    --> src/cargo/util/config/de.rs:530:63
2021-01-25T11:21:52.6410516Z     |
2021-01-25T11:21:52.6411160Z 530 |                 seed.deserialize(Tuple2Deserializer(1i32, env.as_ref()))
2021-01-25T11:21:52.6412405Z     |                                                           ----^^^^^^--
2021-01-25T11:21:52.6413157Z     |                                                           |   |
2021-01-25T11:21:52.6413766Z     |                                                           |   cannot infer type for type parameter `T` declared on the trait `AsRef`
2021-01-25T11:21:52.6419097Z     |                                                           this method call resolves to `&T`
2021-01-25T11:21:52.6419655Z     |
2021-01-25T11:21:52.6420581Z     = note: cannot satisfy `std::string::String: AsRef<_>`
2021-01-25T11:21:52.6421342Z help: use the fully qualified path for the potential candidates
2021-01-25T11:21:52.6421925Z     |
2021-01-25T11:21:52.6422721Z 530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<OsStr>>::as_ref(env)))
2021-01-25T11:21:52.6423727Z     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-01-25T11:21:52.6424649Z 530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<std::path::Path>>::as_ref(env)))
2021-01-25T11:21:52.6425505Z     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-01-25T11:21:52.6426385Z 530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<str>>::as_ref(env)))
2021-01-25T11:21:52.6427202Z     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-01-25T11:21:52.6428044Z 530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<[u8]>>::as_ref(env)))
2021-01-25T11:21:52.6429155Z     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-01-25T11:21:52.6429431Z 
2021-01-25T11:21:55.7044874Z error: aborting due to previous error
2021-01-25T11:21:55.7045355Z 
2021-01-25T11:21:55.7046778Z For more information about this error, try `rustc --explain E0283`.
2021-01-25T11:21:55.7855655Z error: could not compile `cargo`

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021
@bors
Copy link
Contributor

bors commented Jan 25, 2021

⌛ Testing commit 26e67ad with merge e4de1429d0fb363c7e77ff398849d59968c9f84f...

@RalfJung RalfJung mentioned this pull request Jan 25, 2021
Merged
@pietroalbini
Copy link
Member

@bors treeclosed=1000 #81378

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    Checking crates-io v0.31.1 (/tmp/cargo/crates/crates-io)
error[E0283]: type annotations needed
   --> src/cargo/util/config/de.rs:530:63
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, env.as_ref()))
    |                                                           |   |
    |                                                           |   |
    |                                                           |   cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                                                           this method call resolves to `&T`
    |
    = note: cannot satisfy `std::string::String: AsRef<_>`
help: use the fully qualified path for the potential candidates
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<OsStr>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<std::path::Path>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<str>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<[u8]>>::as_ref(env)))

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.

@bors
Copy link
Contributor

bors commented Jan 25, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2021
@bors bors mentioned this pull request Jan 25, 2021
Merged
@RalfJung
Copy link
Member Author

@bors retry
(for when the tree is open again)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021
This was referenced Jan 25, 2021
Merged
Merged
@pietroalbini
Copy link
Member

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Jan 25, 2021

⌛ Testing commit 26e67ad with merge 7fba12b...

@bors
Copy link
Contributor

bors commented Jan 25, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 7fba12b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 25, 2021
@bors bors merged commit 7fba12b into rust-lang:master Jan 25, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 25, 2021
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #81375!

Tested on commit 7fba12b.
Direct link to PR: #81375

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 25, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#81375!
fe1bc21 
Tested on commit rust-lang/rust@7fba12b.
Direct link to PR: <rust-lang/rust#81375>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#81250
6 participants
@RalfJung @bors @rust-log-analyzer @pietroalbini @rust-highfive @rustbot