Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc: Sidebar toggle is not accessible #82582

Closed
tazjin opened this issue Feb 27, 2021 · 0 comments · Fixed by #82584
Closed

Rustdoc: Sidebar toggle is not accessible #82582

tazjin opened this issue Feb 27, 2021 · 0 comments · Fixed by #82584

Comments

@tazjin
Copy link
Contributor

tazjin commented Feb 27, 2021

The sidebar toggle on Rustdoc pages is not recognised as a clickable item by accessibility tooling, making it difficult to toggle in circumstances where mouse usage is difficult.

This is an example of what it currently looks like in Vimium, a common extension for making pages keyboard-accessible:

Screenshot of Vimium hint view on Rustdoc, showing that the sidebar toggle is not highlighted

Other than that, most Rustdoc features seem to be navigable just fine - thanks for that :)
@tazjin tazjin mentioned this issue Feb 27, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#82584 - tazjin:rustdoc-aria, r=GuillaumeGomez
97fd561 
Add ARIA role to sidebar toggle in Rustdoc

This indicates that the div is an interactive element, and makes the sidebar toggle "clickable" in assistive technologies.

Example of Vimium after this change has been applied (see the issue mentioned below for a screenshot of before):

![Screenshot of Vimium link hints on a Rustdoc page, indicating that the sidebar toggle is clickable](https://user-images.githubusercontent.com/1552853/109384961-ff935400-78f8-11eb-8199-1d35181aeff0.png)

Fixes rust-lang#82582
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#82584 - tazjin:rustdoc-aria, r=GuillaumeGomez
a70be0b 
Add ARIA role to sidebar toggle in Rustdoc

This indicates that the div is an interactive element, and makes the sidebar toggle "clickable" in assistive technologies.

Example of Vimium after this change has been applied (see the issue mentioned below for a screenshot of before):

![Screenshot of Vimium link hints on a Rustdoc page, indicating that the sidebar toggle is clickable](https://user-images.githubusercontent.com/1552853/109384961-ff935400-78f8-11eb-8199-1d35181aeff0.png)

Fixes rust-lang#82582
@bors bors closed this as completed in e026e18 Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ARIA role to sidebar toggle in Rustdoc tazjin/rust
1 participant
@tazjin