Add ARIA role to sidebar toggle in Rustdoc #82584
Conversation
This indicates that the div is an interactive element, and makes the sidebar toggle "clickable" in assistive technologies. Fixes rust-lang#82582
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
added
A-rustdoc-ui
|
I'm very curious about something: normally this button only appears on mobile devices where the width is too little. What resolution are you using? |
|
Well, in any case let's get it in (still curious though!). Thanks! @bors: r+ rollup |
|
📌 Commit e026e18 has been approved by |
bors
added
S-waiting-on-bors
|
Thanks for the quick review!
I'm on a standard 1080p resolution (13" laptop screen), however I use a tiling WM with split screen views because I avoid mouse usage due to RSI issues. This way I can have the docs on one half of the screen, and my code on the other. In practice this means that the width of the rendered docs will be <=960px, and it's reasonable that the sidebar would be collapsed at that point :-) |
|
Normally it's under 701px that the sidebar enters the "mobile mode". You need more space. ;) |
Add ARIA role to sidebar toggle in Rustdoc This indicates that the div is an interactive element, and makes the sidebar toggle "clickable" in assistive technologies. Example of Vimium after this change has been applied (see the issue mentioned below for a screenshot of before):  Fixes rust-lang#82582
Rollup of 11 pull requests Successful merges: - rust-lang#81856 (Suggest character encoding is incorrect when encountering random null bytes) - rust-lang#82395 (Add missing "see its documentation for more" stdio) - rust-lang#82401 (Remove a redundant macro) - rust-lang#82498 (Use log level to control partitioning debug output) - rust-lang#82534 (Link crtbegin/crtend on musl to terminate .eh_frame) - rust-lang#82537 (Update measureme dependency to the latest version) - rust-lang#82561 (doc: cube root, not cubic root) - rust-lang#82563 (Fix intra-doc handling of `Self` in enum) - rust-lang#82584 (Add ARIA role to sidebar toggle in Rustdoc) - rust-lang#82596 (clarify RW lock's priority gotcha) - rust-lang#82607 (Add a getter for Frame.loc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This indicates that the div is an interactive element, and makes the sidebar toggle "clickable" in assistive technologies.
Example of Vimium after this change has been applied (see the issue mentioned below for a screenshot of before):
Fixes #82582