-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using an interpolated variable by-ref twice in a macro causes borrowck errors #8367
Labels
A-syntaxext
Area: Syntax extensions
Comments
nikomatsakis
added a commit
to nikomatsakis/rust
that referenced
this issue
Sep 7, 2013
…node has a unique id. Fixes numerous bugs in macro expansion and deriving. Add two representative tests. Fixes rust-lang#7971 Fixes rust-lang#6304 Fixes rust-lang#8367 Fixes rust-lang#8754 Fixes rust-lang#8852
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Feb 24, 2022
Don't lint `needless_borrow` in method receiver positions fixes rust-lang#8408 fixes rust-lang#8407 fixes rust-lang#8391 fixes rust-lang#8367 fixes rust-lang#8380 This is a temporary fix for `needless_borrow`. The proper fix is included in rust-lang#8355. This should probably be merged into rustc before beta branches on Friday. This issue has been reported six or seven times in the past couple of weeks. changelog: Fix various issues with `needless_borrow` n´. Note to changelog writer: those issues might have been introduced in this release cycle, so this might not matter in the changelog.
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Jun 30, 2022
Add lint `explicit_auto_deref` take 2 fixes: rust-lang#234 fixes: rust-lang#8367 fixes: rust-lang#8380 Still things to do: * ~~This currently only lints `&*<expr>` when it doesn't trigger `needless_borrow`.~~ * ~~This requires a borrow after a deref to trigger. So `*<expr>` changing `&&T` to `&T` won't be caught.~~ * The `deref` and `deref_mut` trait methods aren't linted. * Neither ~~field accesses~~, nor method receivers are linted. * ~~This probably shouldn't lint reborrowing.~~ * Full slicing to deref should probably be handled here as well. e.g. `&vec[..]` when just `&vec` would do changelog: new lint `explicit_auto_deref`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using only the
by_val
line compiles fine:The text was updated successfully, but these errors were encountered: