Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noop_fold_view_item doesn't call fold_ident on the paths in a view_item_us #7654

Closed
jbclements opened this issue Jul 8, 2013 · 5 comments
Closed

noop_fold_view_item doesn't call fold_ident on the paths in a view_item_us #7654

jbclements opened this issue Jul 8, 2013 · 5 comments

Comments

@jbclements
Copy link
Contributor

Simple FIXME; no time to fix this now....
@huonw
Copy link
Member

huonw commented Sep 7, 2013

Triage: still an issue, I've got a partial patch in the works.

(@nikomatsakis is this something that you are fixing in your fold fixes?)

@huonw huonw mentioned this issue Sep 7, 2013
Closed
@nikomatsakis
Copy link
Contributor

Yes I have fixed this

@alexcrichton
Copy link
Member

Closing for now (doesn't seem to have an associated test case).

@huonw
Copy link
Member

huonw commented Sep 8, 2013

The fix hasn't landed.

@huonw huonw reopened this Sep 8, 2013
@alexcrichton
Copy link
Member

Oh whoops sorry, I thought that had landed already.

@nikomatsakis nikomatsakis mentioned this issue Sep 9, 2013
Closed
bors added a commit that referenced this issue Sep 10, 2013
@bors
auto merge of #9088 : nikomatsakis/rust/issue-6304-AST-tree-not-DAG, …
753d8c2 
…r=catamorphism

Ensures that each AST node has a unique id. Fixes numerous bugs in macro expansion and deriving. Add two
representative tests.

Fixes #7971
Fixes #6304
Fixes #8367
Fixes #8754
Fixes #8852
Fixes #2543
Fixes #7654
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 28, 2021
@bors
Auto merge of rust-lang#7660 - HKalbasi:derivable-impls, r=camsteffen
e8cd4e5 
Fix derivable impl false positives

fix rust-lang#7654
fix rust-lang#7655

changelog: none (not released)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @nikomatsakis @jbclements @huonw