Skip to content

widening_mul() and carrying_mul() are defined above {integer}::MIN, making the docs harder to read #88736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camelid opened this issue Sep 7, 2021 · 0 comments · Fixed by #89942
Closed

widening_mul() and carrying_mul() are defined above {integer}::MIN, making the docs harder to read #88736

camelid opened this issue Sep 7, 2021 · 0 comments · Fixed by #89942
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Sep 7, 2021

I would expect them to be defined with all the other associated functions, instead of above the constants:

What it looks like on nightly
@camelid camelid added C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 7, 2021
@JohnTitor JohnTitor mentioned this issue Oct 16, 2021
Merged
@bors bors closed this as completed in d6f12f7 Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorder widening_impls to make the doc clearer JohnTitor/rust
1 participant
@camelid