Skip to content

Conversation

JohnTitor
Copy link
Member

Fixes #88736
This moves {widening,carrying}_muls to the bottom to place consts on the top.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2021
@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 28, 2021
@bors
Copy link
Collaborator

bors commented Nov 5, 2021

☔ The latest upstream changes (presumably #90598) made this pull request unmergeable. Please resolve the merge conflicts.

@dtolnay dtolnay force-pushed the reorder-widening_impl branch from b84b2a5 to 0b3a002 Compare November 5, 2021 18:56
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Nov 5, 2021

I pushed a rebase to resolve conflict with #90556.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 5, 2021

📌 Commit 0b3a002 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2021
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#89942 (Reorder `widening_impl`s to make the doc clearer)
 - rust-lang#90569 (Fix tests using `only-i686` to use the correct `only-x86` directive)
 - rust-lang#90597 (Warn for variables that are no longer captured)
 - rust-lang#90623 (Remove more checks for LLVM < 12)
 - rust-lang#90626 (Properly register text_direction_codepoint_in_comment lint.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d6f12f7 into rust-lang:master Nov 6, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 6, 2021
@JohnTitor JohnTitor deleted the reorder-widening_impl branch November 6, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

widening_mul() and carrying_mul() are defined above {integer}::MIN, making the docs harder to read
6 participants