Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc aliases don't work on reexports #96681

Closed
GuillaumeGomez opened this issue May 3, 2022 · 1 comment · Fixed by #96748
Closed

doc aliases don't work on reexports #96681

GuillaumeGomez opened this issue May 3, 2022 · 1 comment · Fixed by #96748
Labels
A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

For example with this code:

#[doc(alias = "->a")]
pub use ::std as x;
#[doc(alias = "->b")]
pub struct Foo;

We can't search for ->a but we can search for ->b.
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-rustdoc-search Area: Rustdoc's search feature labels May 3, 2022
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented May 5, 2022 •
edited
Loading

Actually the problem is even bigger: aliases reexports are not generated for the search index.

@GuillaumeGomez GuillaumeGomez mentioned this issue May 5, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 6, 2022
@GuillaumeGomez
Rollup merge of rust-lang#96748 - GuillaumeGomez:reexports-in-search,…
49d39b6 
… r=notriddle

Fixes reexports in search

Fixes rust-lang#96681.

At some point we stopped reexporting items in search so this PR fixes it.

It also adds a regression test.

r? `@notriddle`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 6, 2022
@GuillaumeGomez
Rollup merge of rust-lang#96748 - GuillaumeGomez:reexports-in-search,…
84bcf5b 
… r=notriddle

Fixes reexports in search

Fixes rust-lang#96681.

At some point we stopped reexporting items in search so this PR fixes it.

It also adds a regression test.

r? ``@notriddle``
@bors bors closed this as completed in 93b86d6 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes reexports in search GuillaumeGomez/rust
1 participant
@GuillaumeGomez