-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes reexports in search #96748
Fixes reexports in search #96748
Conversation
Some changes occurred in HTML/CSS/JS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple nit in an otherwise good PR.
If there's no reason not to use if let
chaining, switch over, then r=me.
Also... fix the ICE. |
cc35120
to
cebf538
Compare
My PR actually had another bug: the sidebar wasn't listing |
This comment has been minimized.
This comment has been minimized.
cebf538
to
3286dfa
Compare
3286dfa
to
fb2f97a
Compare
And fixed. :) |
@bors r+ |
📌 Commit fb2f97a has been approved by |
… r=notriddle Fixes reexports in search Fixes rust-lang#96681. At some point we stopped reexporting items in search so this PR fixes it. It also adds a regression test. r? `@notriddle`
… r=notriddle Fixes reexports in search Fixes rust-lang#96681. At some point we stopped reexporting items in search so this PR fixes it. It also adds a regression test. r? ``@notriddle``
…laumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#96557 (Allow inline consts to reference generic params) - rust-lang#96590 (rustdoc: when running a function-signature search, tweak the tab bar) - rust-lang#96650 (Collect function instance used in `global_asm!` sym operand) - rust-lang#96733 (turn `append_place_to_string` from recursion into iteration) - rust-lang#96748 (Fixes reexports in search) - rust-lang#96752 (Put the incompatible_closure_captures lint messages in alphabetical order) - rust-lang#96754 (rustdoc: ensure HTML/JS side implementors don't have dups) - rust-lang#96772 (Suggest fully qualified path with appropriate params) - rust-lang#96776 (Fix two minor issues in hir.rs) - rust-lang#96782 (a small `mirror_expr` cleanup) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #96681.
At some point we stopped reexporting items in search so this PR fixes it.
It also adds a regression test.
r? @notriddle