-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed> #100368
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
r? @lcnr |
This comment has been minimized.
This comment has been minimized.
ok, that's worrying 😅 you should be able to get a backtrace of where we incorrectly set alternatively, change the can look into this myself in case you get stuck or overwhelmed 😁 sorry, this is not an |
Maybe we found another bug. |
yeah, I am pretty sure that the reason CI is failing is a bug of the current compiler, your PR looks correct. |
seems caused by this line of code,
I commented this line, the crash disappear 🤣 per my understanding, we should only call |
we probably do get some unwanted overflow errors if we remove that, don't we? 🤔 if so fixing that might be difficult. I guess that requires a more general change to the way fulfillment deals with overflow... would have to take some time to experiment with this locally in that case. |
Comfirmed with @cjgillot, this hack used to prob overflow ICE, I tested in local and seems we don't get any overflow diagnostic any more, so I will remove this line. |
@bors r+ rollup |
InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed> Fixes rust-lang#100321. Use Cell<Option<ErrorGuaranteed>> to guarantee that we emit an error when that flag is set.
Rollup of 9 pull requests Successful merges: - rust-lang#99249 (Do not re-parse function signatures to suggest generics) - rust-lang#100309 (Extend comma suggestion to cases where fields arent missing) - rust-lang#100368 (InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed>) - rust-lang#100768 (Migrate `rustc_plugin_impl` to `SessionDiagnostic`) - rust-lang#100835 (net listen backlog update, follow-up from rust-lang#97963.) - rust-lang#100851 (Fix rustc_parse_format precision & width spans) - rust-lang#100857 (Refactor query modifier parsing) - rust-lang#100907 (Fix typo in UnreachableProp) - rust-lang#100909 (Minor `ast::LitKind` improvements) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #100321.
Use Cell<Option> to guarantee that we emit an error when that flag is set.