Rollup of 9 pull requests #100920

Dylan-DPC · 2022-08-23T15:10:11Z

Successful merges:

Do not re-parse function signatures to suggest generics #99249 (Do not re-parse function signatures to suggest generics)
Extend comma suggestion to cases where fields arent missing #100309 (Extend comma suggestion to cases where fields arent missing)
InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed> #100368 (InferCtxt tainted_by_errors_flag should be Option)
Migrate rustc_plugin_impl to SessionDiagnostic #100768 (Migrate rustc_plugin_impl to SessionDiagnostic)
net listen backlog update, follow-up from #97963. #100835 (net listen backlog update, follow-up from net listen backlog set to negative on Linux. #97963.)
Fix rustc_parse_format precision & width spans #100851 (Fix rustc_parse_format precision & width spans)
Refactor query modifier parsing #100857 (Refactor query modifier parsing)
Fix typo in UnreachableProp #100907 (Fix typo in UnreachableProp)
Minor ast::LitKind improvements #100909 (Minor ast::LitKind improvements)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

FreeBSD and using system limit instead for others.

Because it's never used meaningfully.

Do not re-parse function signatures to suggest generics This PR uses the existing resolution rib infrastructure to channel the correct span information to suggest generic parameters. This allows to avoid re-parsing a function's source code. Drive-by cleanup: this removes useless `FnItemRibKind` from late resolution ribs. All the use cases are already covered by `ItemRibKind` and `AssocItemRibKind` which have more precise semantics.

…nxiyn Extend comma suggestion to cases where fields arent missing Fixes rust-lang#100300

InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed> Fixes rust-lang#100321. Use Cell<Option<ErrorGuaranteed>> to guarantee that we emit an error when that flag is set.

… r=davidtwco Migrate `rustc_plugin_impl` to `SessionDiagnostic` Migration of the `rustc_plugin_impl` crate. ~Draft PR because it is blocked on rust-lang#100694 for `#[fatal(...)]` support~ (this has been merged, and I've changed over to `#[diag(...)]` now too), but I would also like to know if what I did with `LoadPluginError` is okay, because all it does is display the error message from `libloading` ([See conversation on zulip](https://rust-lang.zulipchat.com/#narrow/stream/147480-t-compiler.2Fwg-diagnostics/topic/.23100717.20diagnostic.20translation/near/294327843)). This crate is apparently for a deprecated feature which is used by servo, so I don't know how much this matters anyway.

…nexen net listen backlog update, follow-up from rust-lang#97963. FreeBSD and using system limit instead for others.

…fee1-dead Fix rustc_parse_format precision & width spans When a `precision`/`width` was `CountIsName - {:name$}` or `CountIs - {:10}` the `precision_span`/`width_span` was set to `None` For `width` the name span in `CountIsName(_, name_span)` had its `.start` off by one r? ``@fee1-dead`` / cc ``@PrestonFrom`` since this is similar to rust-lang#99987

…=davidtwco Refactor query modifier parsing Reduce redundancy and improve error spans.

…ylan-DPC Fix typo in UnreachableProp r? ``@Dylan-DPC``

…ovement, r=petrochenkov Minor `ast::LitKind` improvements r? `@petrochenkov`

Dylan-DPC · 2022-08-23T15:10:28Z

@bors r+ rollup=never p=5

bors · 2022-08-23T15:10:30Z

📌 Commit 28ead17 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-08-23T15:12:12Z

⌛ Testing commit 28ead17 with merge a1bea15...

bors · 2022-08-23T17:53:24Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing a1bea15 to master...

rust-timer · 2022-08-23T17:56:16Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100909	461f6be773f5ea2bf8493f605fb390d100b52696
#100907	02a800f0088a2d54f2d84880c925cb81795b26b7
#100857	aca1d0d8b8d95e07eebc68597b949c82c7c89ac7
#100851	e7f41a1ebc4a79117b4b9938f9dd6ded3f563522
#100835	59591523f6964346f69aedb29197548cdd376438
#100768	0bbafebddf1a8120a0567b75f6df113db62ffe9a
#100368	d54a2ab3dc628e27d7f84e00855eb0e76008af65
#100309	eeeb72aede357f132497ebf97c2f1b803078b56e
#99249	1a0a2ad7d5705804feee291c763420e2916179d6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-23T19:08:58Z

Finished benchmarking commit (a1bea15): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.0%, 2.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-4.3%	[-7.1%, -2.5%]	4
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

compiler-errors and others added 25 commits August 9, 2022 07:04

Extend comma suggestion to cases where fields arent missing

f4bf8cd

Fix rustc_parse_format precision & width spans

586c84a

Refactor query modifier parsing

c31f296

InferCtxt emit error when incorrectly tainted by errors

8be3764

remove hack fix since we don't have no overflow diagnostic

f466a75

net listen backlog update, follow-up from rust-lang#97963.

15c8e55

FreeBSD and using system limit instead for others.

Migrate rustc_plugin_impl to SessionDiagnostic

8c2413c

Create specific ConstantHasGenerics for ConstantItemRibKind.

d7d701a

Improve local generic parameter suggestions.

613dc22

Do not call generate_fn_name_span in typeck.

362e636

Remove generate_fn_name_span and generate_local_type_param_snippet.

6e88d73

Remove FnItemRibKind.

da9ccc2

Mark suggestion as MaybeIncorrect.

dff4280

Fix typo in UnreachableProp

8e6c5ad

Add some useful comments to LitKind.

fb5dc6b

Remove the symbol from ast::LitKind::Err.

6087dc2

Because it's never used meaningfully.

Rollup merge of rust-lang#100309 - compiler-errors:issue-100300, r=sa…

8733550

…nxiyn Extend comma suggestion to cases where fields arent missing Fixes rust-lang#100300

Rollup merge of rust-lang#100368 - chenyukang:fix-100321, r=lcnr

f42cdf7

InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed> Fixes rust-lang#100321. Use Cell<Option<ErrorGuaranteed>> to guarantee that we emit an error when that flag is set.

Rollup merge of rust-lang#100835 - devnexen:listener_followups, r=dev…

a163659

…nexen net listen backlog update, follow-up from rust-lang#97963. FreeBSD and using system limit instead for others.

Rollup merge of rust-lang#100857 - camsteffen:query-parse-refactor, r…

fd93ab4

…=davidtwco Refactor query modifier parsing Reduce redundancy and improve error spans.

Rollup merge of rust-lang#100907 - Nilstrieb:unrachable-typo-lol, r=D…

12c1ac0

…ylan-DPC Fix typo in UnreachableProp r? ``@Dylan-DPC``

Rollup merge of rust-lang#100909 - nnethercote:minor-ast-LitKind-impr…

28ead17

…ovement, r=petrochenkov Minor `ast::LitKind` improvements r? `@petrochenkov`

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 23, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2022

bors merged commit a1bea15 into rust-lang:master Aug 23, 2022

rustbot added this to the 1.65.0 milestone Aug 23, 2022

This was referenced Aug 23, 2022

Extend and expose API for {:x?} and {:X?} formatting #99138

Closed

add depth_limit in QueryVTable to avoid entering a new tcx in layout_of #100748

Merged

Dylan-DPC deleted the rollup-vlcw3sr branch August 24, 2022 05:34

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #100920

Rollup of 9 pull requests #100920

Dylan-DPC commented Aug 23, 2022

Dylan-DPC commented Aug 23, 2022

bors commented Aug 23, 2022

bors commented Aug 23, 2022

bors commented Aug 23, 2022

rust-timer commented Aug 23, 2022

rust-timer commented Aug 23, 2022

Rollup of 9 pull requests #100920

Rollup of 9 pull requests #100920

Conversation

Dylan-DPC commented Aug 23, 2022

Dylan-DPC commented Aug 23, 2022

bors commented Aug 23, 2022

bors commented Aug 23, 2022

bors commented Aug 23, 2022

rust-timer commented Aug 23, 2022

rust-timer commented Aug 23, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes