Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the armv4t-none-eabi target to the supported_targets #100641

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Add the armv4t-none-eabi target to the supported_targets #100641

merged 2 commits into from
Aug 23, 2022

Conversation

corwinkuiper
Copy link
Contributor

This target was added in #100244 but forgot to add it to the macro in the mod.rs file.

@Lokathor

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 16, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2022
Copy link
Contributor

@Lokathor Lokathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no powers to merge, but I was pinged so I'm going to formally approve it.

@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 22, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 22, 2022

📌 Commit f77a545 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 23, 2022
…oli-obk

Add the armv4t-none-eabi target to the supported_targets

This target was added in rust-lang#100244 but forgot to add it to the macro in the `mod.rs` file.

`@Lokathor`
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100382 (Make the GATS self outlives error take into GATs in the inputs)
 - rust-lang#100565 (Suggest adding a missing semicolon before an item)
 - rust-lang#100641 (Add the armv4t-none-eabi target to the supported_targets)
 - rust-lang#100789 (Use separate infcx to solve obligations during negative coherence)
 - rust-lang#100832 (Some small bootstrap cleanup)
 - rust-lang#100861 (fix ICE with extra-const-ub-checks)
 - rust-lang#100862 (tidy: remove crossbeam-utils)
 - rust-lang#100887 (Refactor part of codegen_call_terminator)
 - rust-lang#100893 (Remove out-of-context comment in `mem::MaybeUninit` documentation)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 44aa866 into rust-lang:master Aug 23, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 23, 2022
@corwinkuiper corwinkuiper deleted the add-armv4t-target branch August 23, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants