Use separate infcx to solve obligations during negative coherence #100789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Aug 20, 2022
| @@ -1,10 +1,15 @@ | |||
| // revisions: stock with_negative_coherence | |||
There was a problem hiding this comment.
I just made this into a separate revision instead of a different test since it kinda makes sense for this to also be tracked here
compiler-errors
commented
Aug 20, 2022
|
|
||
| // FIXME: this should compile | ||
|
|
||
| trait MyPredicate<'a> {} | ||
| impl<'a, T> !MyPredicate<'a> for &T where T: 'a {} | ||
|
|
||
| impl<'a, T> !MyPredicate<'a> for &'a T where T: 'a {} |
There was a problem hiding this comment.
for &'a T seems like a better representation of the case which should pass, but let me know and I can revert. This ICE happens regardless of it, so it doesn't affect the test for the ICE I'm fixing.
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
issue-99662
branch
from
4c66cf7 to
ba72729
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 23, 2022
…storino Use separate infcx to solve obligations during negative coherence I feel like I fixed this already but I may have fixed it then forgot to push the branch... Also fixes up some redundant param-envs being passed around (since they're already passed around in the `Obligation`) Fixes rust-lang#99662 r? `@spastorino`
This was referenced Aug 23, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#100382 (Make the GATS self outlives error take into GATs in the inputs) - rust-lang#100565 (Suggest adding a missing semicolon before an item) - rust-lang#100641 (Add the armv4t-none-eabi target to the supported_targets) - rust-lang#100789 (Use separate infcx to solve obligations during negative coherence) - rust-lang#100832 (Some small bootstrap cleanup) - rust-lang#100861 (fix ICE with extra-const-ub-checks) - rust-lang#100862 (tidy: remove crossbeam-utils) - rust-lang#100887 (Refactor part of codegen_call_terminator) - rust-lang#100893 (Remove out-of-context comment in `mem::MaybeUninit` documentation) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 24, 2022
…s-implied-bounds, r=lcnr Coherence negative impls implied bounds Fixes rust-lang#93875 This PR is rebased on top of rust-lang#100789 and it would need to include that one which is already r+ed. r? ``@nikomatsakis`` cc ``@lcnr`` (which I've talked about rust-lang@3222f42, I guess after you finish your reordering of modules and work with OutlivesEnvironmentEnv this commit can just be reverted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like I fixed this already but I may have fixed it then forgot to push the branch...
Also fixes up some redundant param-envs being passed around (since they're already passed around in the
Obligation)Fixes #99662
r? @spastorino