Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffx component run should provide a collection #101347

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

diminishedprime
Copy link
Contributor

In the future,ffx component run will not default to the using the /core/ffx-laboratory collection. Updated the run commands to include this.

In the future,`ffx component run` will not default to the using the `/core/ffx-laboratory` collection. Updated the run commands to include this.
@rust-highfive
Copy link
Collaborator

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2022
@ehuss
Copy link
Contributor

ehuss commented Sep 3, 2022

r? @tmandry

@rust-highfive rust-highfive assigned tmandry and unassigned ehuss Sep 3, 2022
@tmandry
Copy link
Member

tmandry commented Sep 3, 2022

Thanks!

Btw, you can say r? @tmandry in your pull request description and it'll go straight to me.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 3, 2022

📌 Commit c528f70 has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 3, 2022
ffx component run should provide a collection

In the future,`ffx component run` will not default to the using the `/core/ffx-laboratory` collection. Updated the run commands to include this.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2022
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#101335 (rustdoc: remove old CSS selector that causes weird spacing)
 - rust-lang#101347 (ffx component run should provide a collection)
 - rust-lang#101364 (Shrink suggestion span of argument mismatch error)
 - rust-lang#101365 (remove redundant clones)

Failed merges:

 - rust-lang#101349 (rustdoc: remove `.impl-items { flex-basis }` CSS, not in flex container)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 525e386 into rust-lang:master Sep 3, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants