rustdoc: remove .impl-items { flex-basis } CSS, not in flex container
#101349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 3, 2022
|
I confirmed there were no changes. Good catch! @bors r+ rollup |
|
📌 Commit 7ba5f43740f3e5b66aa0b98b1c824d30753aa97f has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#101335 (rustdoc: remove old CSS selector that causes weird spacing) - rust-lang#101347 (ffx component run should provide a collection) - rust-lang#101364 (Shrink suggestion span of argument mismatch error) - rust-lang#101365 (remove redundant clones) Failed merges: - rust-lang#101349 (rustdoc: remove `.impl-items { flex-basis }` CSS, not in flex container) r? `@ghost` `@rustbot` modify labels: rollup
|
☔ The latest upstream changes (presumably #101378) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Added in 34bd2b8 For this to actually do anything, [according to MDN] (and Firefox Dev Tools), it must be a "flex item", which only happens if its a direct child of a node with `display: flex` on it. It seems like it could not have worked at the time when this rule was added, because the only items in `rustdoc.css` with `display: flex` active were: * `#help` This should not contain anything like this. * `.impl-items h4, h4.impl, h3.impl` These are all headers, so they shouldn't contain `.impl-items` either. * `.content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant` Associated constants and methods definitely shouldn't contain a list of impl items, and the `.type` class seems to refer to type aliases, which, when shown inside of an impl, only show a link to the aliased type. [according to MDN]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis Nowadays, `display: flex` is a lot more prolific, but `.impl-items` still seems to only be used in plain block parents: * If it's not a trait impl, then it's nested below a `<div>` with an id but no class, added in a5216cf. This will be `display: block`, probably. For example, [vec deref] * Inherent impls also get a `<div>` tag, for example [vec impl], and they are also wrapped by their own non-flexbox `<details>` tag. * If it's a tait implementation, then it's also nested below a `<details>` container, like [deref cstring]. [vec impl]: https://doc.rust-lang.org/1.63.0/std/vec/struct.Vec.html#impl [vec deref]: https://doc.rust-lang.org/1.63.0/std/vec/struct.Vec.html#deref-methods-%5BT%5D [deref cstring]: https://doc.rust-lang.org/1.63.0/std/ops/trait.Deref.html#impl-Deref Also, this would imply that trait items ought to take up as much space as possible, pushing everything else to the edge of the screen. If this is nested directly below the `.rustdoc` container, which has a row basis, that would be bad.
notriddle
force-pushed
the
notriddle/flex-basis
branch
from
7ba5f43 to
cee90dd
Compare
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#100302 (Suggest associated method on deref types when path syntax method fails) - rust-lang#100647 ( Make trait bound not satisfied specify kind) - rust-lang#101349 (rustdoc: remove `.impl-items { flex-basis }` CSS, not in flex container) - rust-lang#101369 (Fix `global_asm` macro pretty printing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in 34bd2b8
For this to actually do anything, according to MDN (and Firefox Dev Tools), it must be a "flex item", which only happens if its a direct child of a node with
display: flexon it. It seems like it could not have worked at the time when this rule was added, because the only items inrustdoc.csswithdisplay: flexactive were:#helpThis should not contain anything like this.
.impl-items h4, h4.impl, h3.implThese are all headers, so they shouldn't contain
.impl-itemseither..content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstantAssociated constants and methods definitely shouldn't contain a list of impl items, and the
.typeclass seems to refer to type aliases, which, when shown inside of an impl, only show a link to the aliased type.Nowadays,
display: flexis a lot more prolific, but.impl-itemsstill seems to only be used in plain block parents:<div>with an id but no class, added in a5216cf. This will bedisplay: block, probably. For example, vec deref<div>tag, for example vec impl, and they are also wrapped by their own non-flexbox<details>tag.<details>container, like deref cstring.Also, this would imply that trait items ought to take up as much space as possible, pushing everything else to the edge of the screen. If this is nested directly below the
.rustdoccontainer, which has a row basis, that would be bad.