Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more cleanup in core #101412

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Some more cleanup in core #101412

merged 2 commits into from
Sep 6, 2022

Conversation

WaffleLapkin
Copy link
Member

r? @scottmcm

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 4, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022
@scottmcm
Copy link
Member

scottmcm commented Sep 6, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 6, 2022

📌 Commit 5a67292 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2022
@bors
Auto merge of rust-lang#101479 - Dylan-DPC:rollup-v8ite0y, r=Dylan-DPC
3c72788 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#100658 (TyCtxt::get_attr should check that no duplicates are allowed)
 - rust-lang#101021 (Migrate ``rustc_middle`` diagnostic)
 - rust-lang#101287 (Document eager evaluation of `bool::then_some` argument)
 - rust-lang#101412 (Some more cleanup in `core`)
 - rust-lang#101427 (Fix ICE, generalize 'move generics to trait' suggestion for >0 non-rcvr arguments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 00db13f into rust-lang:master Sep 6, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 6, 2022
@WaffleLapkin WaffleLapkin deleted the improve_std_ptr_code_leftovers branch September 6, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@WaffleLapkin @rustbot @scottmcm @bors @rust-highfive