-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #101479
Rollup of 5 pull requests #101479
Conversation
…r=lcnr TyCtxt::get_attr should check that no duplicates are allowed Fixes rust-lang#100631
Migrate ``rustc_middle`` diagnostic Part of rust-lang#100717
…scottmcm Document eager evaluation of `bool::then_some` argument I encountered this earlier today and thought maybe `bool::then_some` could use a little addition to the documentation. It's pretty obvious with familiarity and from looking at the implementation, but the argument for `then_some` is eagerly evaluated, which means if you do the following (as I did), you can have a problem: ```rust // Oops! let _ = something .has_another_thing() .then_some(something.another_thing_or_panic()); ``` A note, similar to other methods with eagerly-evaluated arguments and a lazy alternative (`Option::or`, for example), could help point this out to people who forget (like me)!
…leftovers, r=scottmcm Some more cleanup in `core` - remove some integer casts from slice iter (proposed in rust-lang#100819 (comment)) - replace `as usize` casts with `usize::from` in slice sort (proposed in rust-lang#100822 (comment)) r? `@scottmcm`
…gillot Fix ICE, generalize 'move generics to trait' suggestion for >0 non-rcvr arguments Fixes rust-lang#101421 cc rust-lang#100838
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: a594044533 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (3c72788): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Looks like the current noise/bimodality of |
Successful merges:
rustc_middle
diagnostic #101021 (Migraterustc_middle
diagnostic)bool::then_some
argument #101287 (Document eager evaluation ofbool::then_some
argument)core
#101412 (Some more cleanup incore
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup