Rollup of 9 pull requests #101716

Dylan-DPC · 2022-09-12T09:51:37Z

Successful merges:

Add inline-llvm option for disabling/enabling LLVM inlining #100293 (Add inline-llvm option for disabling/enabling LLVM inlining)
Remove manual <[u8]>::escape_ascii #100767 (Remove manual <[u8]>::escape_ascii)
Suggest pub instead of public for const type item #101668 (Suggest pub instead of public for const type item)
Fix naming format of IEEE 754 standard #101671 (Fix naming format of IEEE 754 standard)
Check that the types in return position impl Trait in traits are well-formed #101676 (Check that the types in return position impl Trait in traits are well-formed)
Deny return-position impl Trait in traits for object safety #101681 (Deny return-position impl Trait in traits for object safety)
Update browser UI test to 0.10 #101693 (Update browser UI test 0 10)
Rustdoc-Json: Add tests for trait impls. #101701 (Rustdoc-Json: Add tests for trait impls.)
rustdoc: remove no-op #search #101706 (rustdoc: remove no-op #search)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Currently the documentation of f64::min refers to "IEEE-754 2008" while the documentation of f64::minimum refers to "IEEE 754-2019". Note that one has the format IEEE,hyphen,number,space,year while the other is IEEE,space,number,hyphen,year. The official IEEE site [1] uses the later format and it is also the one most commonly used throughout the codebase. Update all comments and - more importantly - documentation to consistently use the official format. [1] https://standards.ieee.org/ieee/754/4211/

This rule was added in c729e4d to remove an unnecessary left margin that was present on desktop. This desktop-mode margin was itself removed in 135281e.

The padding rule was added in 135281e when converting the rule for #main, but didn't do anything even then.

…, r=nnethercote Add inline-llvm option for disabling/enabling LLVM inlining In this PR, a new -Z option `inline-llvm` is added in order to be able to turn on/off LLVM inlining. The capability of turning on/off inlining in LLVM backend is needed for testing performance implications of using recently enabled inlining in rustc's frontend (with -Z inline-mir=yes option, rust-lang#91743). It would be interesting to see the performance effect using rustc's frontend inlining only without LLVM inlining enabled. Currently LLVM is still doing inlining no mater what value inline-mir is set to. With the option `inline-llvm` being added in this PR, user can turn off LLVM inlining by using `-Z inline-llvm=no` option (the default of inline-llvm is 'yes', LLVM inlining enabled).

Remove manual <[u8]>::escape_ascii `@rustbot` label: +C-cleanup

Suggest pub instead of public for const type item Fixes rust-lang#101626

Fix naming format of IEEE 754 standard Currently the documentation of f64::min refers to "IEEE-754 2008" while the documentation of f64::minimum refers to "IEEE 754-2019". Note that one has the format IEEE,hyphen,number,space,year while the other is IEEE,space,number,hyphen,year. The official IEEE site [1] uses the later format and it is also the one most commonly used throughout the codebase. Update all comments and - more importantly - documentation to consistently use the official format. [1] https://standards.ieee.org/ieee/754/4211/

Check that the types in return position `impl Trait` in traits are well-formed This effectively duplicates `check_associated_type_bounds`, but that shouldn't be for long, since we're going to remove it once we refactor RPITITs into regular associated items. Fixes rust-lang#101663 --- We don't check ```rust trait Foo { fn bar() -> impl ?Sized; } ``` currently, but that's for a different reason, which is that we don't currently check that a trait function's return type is sized (i.e. `fn bar() -> [u8]` also works in a trait).

… r=lcnr Deny return-position `impl Trait` in traits for object safety Fixes rust-lang#101667

…est-0-10, r=notriddle Update browser UI test 0 10 The biggest change from this browser-ui-test update is the upgrade of the puppeteer version to `17.1.3` (the latest in short). I also added the command `click-with-offset` to still allow us to click on the `[-]` part. cc `@jsha` r? `@notriddle`

…illaumeGomez Rustdoc-Json: Add tests for trait impls.

… r=GuillaumeGomez rustdoc: remove no-op `#search` The margin rule was added in c729e4d to remove an unnecessary left margin that was present on desktop. This desktop-mode margin was itself removed in 135281e. The padding rule was added in 135281e when converting the rule for `#main`, but didn't do anything even then.

Dylan-DPC · 2022-09-12T09:52:00Z

@bors r+ rollup=never p=5

bors · 2022-09-12T09:52:03Z

📌 Commit 9bf89e7 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-09-12T11:36:43Z

⌛ Testing commit 9bf89e7 with merge 881c4e9d3de032824d8faa4fc82977983c1a1f7a...

rust-log-analyzer · 2022-09-12T11:48:23Z

The job i686-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

* highest error code: E0790
Found 506 error codes
Found 0 error(s) in error codes
Done!
thread '<unnamed>' panicked at 'cmd.exec() failed with `cargo metadata` exited with an error:     Updating git repository `https://github.com/bjorn3/rust-ar.git`
warning: spurious network error (2 tries remaining): request failed with status code: 503; class=Http (34)
warning: spurious network error (1 tries remaining): request failed with status code: 503; class=Http (34)
error: failed to get `ar` as a dependency of package `rustc_codegen_cranelift v0.1.0 (D:\a\rust\rust\compiler\rustc_codegen_cranelift)`
Caused by:
  failed to load source for dependency `ar`

Caused by:
Caused by:
  Unable to update https://github.com/bjorn3/rust-ar.git?branch=do_not_remove_cg_clif_ranlib#de9ab0e5

Caused by:
  failed to clone into: C:\Users\runneradmin\.cargo\git\db\rust-ar-9b35aff8ad678e06
Caused by:
  network failure seems to have happened
  if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  request failed with status code: 503; class=Http (34)', src\tools\tidy\src\deps.rs:341:20
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', src\tools\tidy\src/main.rs:77:9
Build completed unsuccessfully in 0:01:06
make: *** [Makefile:83: ci-mingw-subset-1] Error 1

bors · 2022-09-12T11:49:08Z

⌛ Testing commit 9bf89e7 with merge b76d6fc1ed6ad1897e56bc23a390a87b6dfe2e14...

bors · 2022-09-12T11:51:11Z

💔 Test failed - checks-actions

Dylan-DPC · 2022-09-12T11:55:21Z

@bors treeclosed=1000

Dylan-DPC · 2022-09-12T13:16:04Z

@bors r+ rollup=never p=1001

bors · 2022-09-12T13:16:07Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors · 2022-09-12T13:16:08Z

📌 Commit 9bf89e7 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-09-12T13:16:08Z

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

bors · 2022-09-12T13:16:18Z

⌛ Testing commit 9bf89e7 with merge 7f115e3...

Dylan-DPC · 2022-09-12T14:55:15Z

@bors treeclosed-

bors · 2022-09-12T15:57:31Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 7f115e3 to master...

rust-timer · 2022-09-12T16:00:19Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101706	114f1f34345431f306737f2a9302b2e7de0f34fe
#101701	4cefdacf41f0f909b53265ada205251f0deb556f
#101693	8155aa53bdf6a8571039809f58f0811821519910
#101681	c02afeb49870300ea143647bcaf20e4bbf96637e
#101676	d0842428ad119f25198e33bc4dd3a6036731f368
#101671	7a35b13115450b87985c49f4f13d7409570157a8
#101668	42fa02c28d8447a0c5832086be336b1238b827c7
#100767	4af4545e8ceeccc623f8c1a98cca3d7b51aed778
#100293	04ea53fc644f59fa819c9f8a5d56cb53ed70d9c6

previous master: a93214ec06

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-log-analyzer · 2022-09-12T16:32:17Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-timer · 2022-09-12T17:14:05Z

Finished benchmarking commit (7f115e3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	-3.1%	[-3.1%, -3.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

kadiwa4 and others added 20 commits August 19, 2022 19:00

use <[u8]>::escape_ascii instead of core::ascii::escape_default

a297631

Add inline-llvm option for disabling/enabling LLVM inlining

052887e

Update browser-ui-test version to 0.10.0

9c3cb2d

fix rust-lang#101626, suggest pub instead of public for const type item

975dd6c

Check that the types in RPITITs are WF

fd2766e

Deny RPITIT for object safety

89b6488

Rustdoc-Json: Add tests for trait impls.

c3fcfa8

Update tests for new browser-ui-test version

d010f95

rustdoc: remove no-op #search { margin-left: 0 }

bff8078

This rule was added in c729e4d to remove an unnecessary left margin that was present on desktop. This desktop-mode margin was itself removed in 135281e.

rustdoc: remove no-op #search

2d239fb

The padding rule was added in 135281e when converting the rule for #main, but didn't do anything even then.

Rollup merge of rust-lang#100767 - kadiwa4:escape_ascii, r=jackh726

9317775

Remove manual <[u8]>::escape_ascii `@rustbot` label: +C-cleanup

Rollup merge of rust-lang#101668 - chenyukang:fix-101626, r=TaKO8Ki

d7bad03

Suggest pub instead of public for const type item Fixes rust-lang#101626

Rollup merge of rust-lang#101681 - compiler-errors:rpitit-obj-safety,…

6bacb6f

… r=lcnr Deny return-position `impl Trait` in traits for object safety Fixes rust-lang#101667

Rollup merge of rust-lang#101701 - aDotInTheVoid:rdj-impl-tests, r=Gu…

228a8bd

…illaumeGomez Rustdoc-Json: Add tests for trait impls.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 12, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2022

bors mentioned this pull request Sep 12, 2022

translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Final #101266

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2022

bors merged commit 7f115e3 into rust-lang:master Sep 12, 2022

rustbot added this to the 1.65.0 milestone Sep 12, 2022

bors mentioned this pull request Sep 12, 2022

Shrink ast::Expr harder #101562

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #101716

Rollup of 9 pull requests #101716

Dylan-DPC commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

rust-log-analyzer commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

bors commented Sep 12, 2022

rust-timer commented Sep 12, 2022

rust-log-analyzer commented Sep 12, 2022

rust-timer commented Sep 12, 2022

Rollup of 9 pull requests #101716

Rollup of 9 pull requests #101716

Conversation

Dylan-DPC commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

rust-log-analyzer commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

bors commented Sep 12, 2022

Dylan-DPC commented Sep 12, 2022

bors commented Sep 12, 2022

rust-timer commented Sep 12, 2022

rust-log-analyzer commented Sep 12, 2022

rust-timer commented Sep 12, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes