Skip to content

A SubstitutionPart is not considered a deletion if it replaces nothing with nothing #101700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2022
Merged

A SubstitutionPart is not considered a deletion if it replaces nothing with nothing #101700

merged 3 commits into from
Sep 13, 2022

Conversation

@compiler-errors
Copy link
Member

Fixes #101689

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 11, 2022
@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
compiler-errors
compiler-errors commented Sep 11, 2022
View reviewed changes
@lcnr
Copy link
Contributor

lcnr commented Sep 12, 2022

r? compiler

@rust-highfive rust-highfive assigned davidtwco and unassigned lcnr Sep 12, 2022
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

📌 Commit 3bf33c3 has been approved by davidtwco

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101700 - compiler-errors:deletion-span, r=d…
091e699 
…avidtwco

A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing

Fixes rust-lang#101689
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 12, 2022
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101700 - compiler-errors:deletion-span, r=d…
8bb913d 
…avidtwco

A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing

Fixes rust-lang#101689
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 12, 2022
Closed
@compiler-errors
Copy link
Member Author

@bors r- (#101733 (comment))

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2022
@compiler-errors compiler-errors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2022
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 13, 2022

📌 Commit cd962e6 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 13, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#101700 - compiler-errors:deletion-span, r=d…
5e0f6bb 
…avidtwco

A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing

Fixes rust-lang#101689
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2022
@bors
Auto merge of rust-lang#101757 - Dylan-DPC:rollup-wkt6oe9, r=Dylan-DPC
5338f5f 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#101602 (Streamline `AttrAnnotatedTokenStream`)
 - rust-lang#101690 (Avoid `Iterator::last`)
 - rust-lang#101700 (A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing)
 - rust-lang#101745 (Fix typo in concat_bytes documentation)
 - rust-lang#101748 (rustdoc: remove redundant CSS `#source-sidebar, #sidebar-toggle`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit adcd1fb into rust-lang:master Sep 13, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 13, 2022
@compiler-errors compiler-errors deleted the deletion-span branch November 2, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

Improve and make missing dyn help suggestion more uniform

6 participants

@compiler-errors @rust-highfive @lcnr @davidtwco @bors @rustbot