rustdoc: remove redundant CSS #source-sidebar, #sidebar-toggle
#101748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 13, 2022
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
This is used in at least one place on docs.rs, not sure if there will be any styling issues without it |
|
It shouldn't be impacted. On docs.rs it's needed because of the docs.rs top navbar. |
|
Ah, I should have looked at the diff, I thought it was removing the id from the html too 😅 |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 13, 2022
…-sidebar-toggle, r=GuillaumeGomez rustdoc: remove redundant CSS `#source-sidebar, #sidebar-toggle` These two elements are always nested below `<nav class="sidebar">`, and will inherit the font from their parent. These selectors were added in 93520d2, and became redundant in 07e3f99 when the source sidebar elements became nested below `nav.sidebar`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#101602 (Streamline `AttrAnnotatedTokenStream`) - rust-lang#101690 (Avoid `Iterator::last`) - rust-lang#101700 (A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing) - rust-lang#101745 (Fix typo in concat_bytes documentation) - rust-lang#101748 (rustdoc: remove redundant CSS `#source-sidebar, #sidebar-toggle`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two elements are always nested below
<nav class="sidebar">, and will inherit the font from their parent.These selectors were added in 93520d2, and became redundant in 07e3f99 when the source sidebar elements became nested below
nav.sidebar.