-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve async fn signature even without body (e.g., in trait) #102161
Conversation
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
r=me after comments |
Ugh, actually this passes now and might not after the changes: fn main() {}
trait Foo {
fn fn_with_type_named_same_as_local_in_param(b: i32, b: i32);
} Let me see if I can avoid this. |
3ba9fab
to
271a068
Compare
Okay, fixed that bug by just doing the only part of resolve that we need for AFIT. |
r? @tmandry |
@bors r+ |
📌 Commit 271a0680197e08405c67dd0b4d4bac87ea9a28bc has been approved by It is now in the queue for this repository. |
Actually, want to add a test for this? (and r=me) Not sure it's the behavior I would want, but it's too late for that anyway :) @bors r- |
5029212
to
e87fcc0
Compare
@bors r=tmandry |
…andry Resolve async fn signature even without body (e.g., in trait) Fixes rust-lang#102138 This "bail if no body" behavior was introduced in rust-lang#69539 to fix rust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#102016 (implied_bounds: deal with inference vars) - rust-lang#102161 (Resolve async fn signature even without body (e.g., in trait)) - rust-lang#102216 (rustdoc: Stabilize --diagnostic-width) - rust-lang#102240 (rustdoc: remove unused CSS `#main-content > .line-numbers`) - rust-lang#102242 (rustdoc: remove unused CSS `.summary`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #102138
This "bail if no body" behavior was introduced in #69539 to fix #69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.