Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove unused CSS #main-content > .line-numbers #102240

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

notriddle
Copy link
Contributor

This selector was added in 10b9370. It became unreachable when 09150f8 made it so that .line-numbers are always nested below .example-wrap, even on source pages.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 24, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2022
This selector was added in 10b9370. It
became unreachable when 09150f8 made it so
that `.line-numbers` are always nested below `.example-wrap`, even on
source pages.
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Sep 24, 2022

📌 Commit a0be6c4 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 24, 2022
…ers, r=GuillaumeGomez

rustdoc: remove unused CSS `#main-content > .line-numbers`

This selector was added in 10b9370. It became unreachable when 09150f8 made it so that `.line-numbers` are always nested below `.example-wrap`, even on source pages.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2022
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#102016 (implied_bounds: deal with inference vars)
 - rust-lang#102161 (Resolve async fn signature even without body (e.g., in trait))
 - rust-lang#102216 (rustdoc: Stabilize --diagnostic-width)
 - rust-lang#102240 (rustdoc: remove unused CSS `#main-content > .line-numbers`)
 - rust-lang#102242 (rustdoc: remove unused CSS `.summary`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d870b93 into rust-lang:master Sep 25, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants