-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#102929) Implement String::leak
(attempt 2)
#103280
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
@rustbot label -T-libs |
String:leak
(attempt 2)String::leak
(attempt 2)
@bors r+ |
…htriplett (rust-lang#102929) Implement `String::leak` (attempt 2) Implementation of `String::leak` (rust-lang#102929) ACP: rust-lang/libs-team#109 Supersedes rust-lang#102941 (see previous reviews there) `@rustbot` label +T-libs-api -T-libs
…htriplett (rust-lang#102929) Implement `String::leak` (attempt 2) Implementation of `String::leak` (rust-lang#102929) ACP: rust-lang/libs-team#109 Supersedes rust-lang#102941 (see previous reviews there) ``@rustbot`` label +T-libs-api -T-libs
Rollup of 7 pull requests Successful merges: - rust-lang#102602 (Slightly tweak comments wrt `lint_overflowing_range_endpoint`) - rust-lang#103190 (rustdoc: render bounds of cross-crate GAT params) - rust-lang#103224 (Allow semicolon after closure within parentheses in macros) - rust-lang#103280 ((rust-lang#102929) Implement `String::leak` (attempt 2)) - rust-lang#103329 (Add a forgotten check for NonNull::new_unchecked's precondition) - rust-lang#103346 (Adjust argument type for mutable with_metadata_of (rust-lang#75091)) - rust-lang#103360 (Reduce false positives in msys2 detection) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…, r=thomcc Fix typo in docs of `String::leak`. I introduced a typo in rust-lang#103280, this PR fixes it. See rust-lang#103280 (comment)
…, r=thomcc Fix typo in docs of `String::leak`. I introduced a typo in rust-lang#103280, this PR fixes it. See rust-lang#103280 (comment)
…, r=thomcc Fix typo in docs of `String::leak`. I introduced a typo in rust-lang#103280, this PR fixes it. See rust-lang#103280 (comment)
…, r=thomcc Fix typo in docs of `String::leak`. I introduced a typo in rust-lang#103280, this PR fixes it. See rust-lang#103280 (comment)
Implementation of
String::leak
(#102929)ACP: rust-lang/libs-team#109
Supersedes #102941 (see previous reviews there)
@rustbot label +T-libs-api -T-libs