Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused lint and parser caring about spaces to won't produce invalid code #103468

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Fix unused lint and parser caring about spaces to won't produce invalid code #103468

merged 2 commits into from
Nov 11, 2022

Conversation

chenyukang
Copy link
Member

Fixes #103435

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 24, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2022
@chenyukang chenyukang force-pushed the yukang/fix-103435-extra-parentheses branch from 02b1c45 to c0447b4 Compare October 24, 2022 09:14
@cjgillot
Copy link
Contributor

Should we suggest to replace the parenthesis with a space in all cases, and let rustfmt cleanup after rustc?

@chenyukang
Copy link
Member Author

chenyukang commented Oct 24, 2022 •
edited
Loading

That is an optional solution,
but it seems a little weird when the suggestion snippet is printed on console:

if let (a) = 0 {}

suggest to be:

if let  a  = 0 {}

@compiler-errors
Copy link
Member

Do you mind renaming this PR to mention the actual issue, specifically "spaces"?

@chenyukang chenyukang changed the title Unused lint won't produce invalid code Fix unused lint and parser caring about spaces to won't produce invalid code Oct 25, 2022
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 10, 2022

📌 Commit a46af18 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 11, 2022
@Manishearth
Rollup merge of rust-lang#103468 - chenyukang:yukang/fix-103435-extra…
6c35e1a 
…-parentheses, r=estebank

Fix unused lint and parser caring about spaces to won't produce invalid code

Fixes rust-lang#103435
@Manishearth Manishearth mentioned this pull request Nov 11, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 11, 2022
@Manishearth
Rollup merge of rust-lang#103468 - chenyukang:yukang/fix-103435-extra…
a778ce3 
…-parentheses, r=estebank

Fix unused lint and parser caring about spaces to won't produce invalid code

Fixes rust-lang#103435
@Manishearth Manishearth mentioned this pull request Nov 11, 2022
Closed
@Manishearth Manishearth mentioned this pull request Nov 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2022
@bors
Auto merge of rust-lang#104293 - Manishearth:rollup-xj92d0k, r=Manish…
42325c5 
…earth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#95292 (Allow specialized const trait impls.)
 - rust-lang#100386 (Make `Sized` coinductive, again)
 - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`)
 - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code)
 - rust-lang#103531 (Suggest calling the instance method of the same name when method not found)
 - rust-lang#103960 (piece of diagnostic migrate)
 - rust-lang#104051 (update Miri)
 - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fd5ff82 into rust-lang:master Nov 11, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 11, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@Manishearth
Rollup merge of rust-lang#103468 - chenyukang:yukang/fix-103435-extra…
399f297 
…-parentheses, r=estebank

Fix unused lint and parser caring about spaces to won't produce invalid code

Fixes rust-lang#103435
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#104293 - Manishearth:rollup-xj92d0k, r=Manish…
174aef4 
…earth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#95292 (Allow specialized const trait impls.)
 - rust-lang#100386 (Make `Sized` coinductive, again)
 - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`)
 - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code)
 - rust-lang#103531 (Suggest calling the instance method of the same name when method not found)
 - rust-lang#103960 (piece of diagnostic migrate)
 - rust-lang#104051 (update Miri)
 - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Compiler warns to remove parentheses producing invalid code
7 participants
@chenyukang @rust-highfive @cjgillot @compiler-errors @estebank @bors @rustbot