Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generation of tuple struct fields in the search index #103799

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Remove generation of tuple struct fields in the search index #103799

merged 2 commits into from
Nov 1, 2022

Conversation

GuillaumeGomez
Copy link
Member

This comes from this discussion as they're not very useful.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 31, 2022
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 31, 2022
@bors
Copy link
Contributor

bors commented Oct 31, 2022

⌛ Trying commit 5062a77 with merge 8d08687ba9abdf11ea7dcedd6300e421c2396a9c...

@bors
Copy link
Contributor

bors commented Oct 31, 2022

☀️ Try build successful - checks-actions
Build commit: 8d08687ba9abdf11ea7dcedd6300e421c2396a9c (8d08687ba9abdf11ea7dcedd6300e421c2396a9c)

@rust-timer
Copy link
Collaborator

Queued 8d08687ba9abdf11ea7dcedd6300e421c2396a9c with parent 4596f4f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d08687ba9abdf11ea7dcedd6300e421c2396a9c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 31, 2022
@notriddle
Copy link
Contributor

doc-bytes results https://perf.rust-lang.org/compare.html?start=4596f4f8b565bdd02d3b99d1ab12ff09146a93de&end=8d08687ba9abdf11ea7dcedd6300e421c2396a9c&stat=size%3Adoc_bytes:

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.02% [ -0.03%, -0.01%] 6
Improvements ✅
(secondary)		 -0.30% [ -0.76%, -0.04%] 3
All ❌✅ (primary) -0.02% [ -0.03%, -0.01%] 6

@GuillaumeGomez
Copy link
Member Author

It's more than I expected.

@notriddle
Copy link
Contributor

In any case,

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 31, 2022

📌 Commit 5062a77 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2022
@JohnTitor JohnTitor mentioned this pull request Nov 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2022
@bors
Auto merge of rust-lang#103829 - JohnTitor:rollup-o03nzr8, r=JohnTitor
dc05f60 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#103007 (Add better python discovery)
 - rust-lang#103674 (Update note about unstable split-debuginfo flag.)
 - rust-lang#103692 (Add `walk_generic_arg`)
 - rust-lang#103749 (Reduce span of let else irrefutable_let_patterns warning)
 - rust-lang#103772 (better error for `rustc_strict_coherence` misuse)
 - rust-lang#103788 (Fix ICE in checking transmutability of NaughtyLenArray)
 - rust-lang#103793 (rustdoc: add margins to all impl-item toggles, not just methods)
 - rust-lang#103798 (interpret: move type_name implementation to an interpreter-independent helper file)
 - rust-lang#103799 (Remove generation of tuple struct fields in the search index)
 - rust-lang#103805 (Enable RUSTC_BOOTSTRAP for a few steps)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fca9093 into rust-lang:master Nov 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 1, 2022
@GuillaumeGomez GuillaumeGomez deleted the search-index-tuple-struct-field branch November 1, 2022 09:30
@notriddle notriddle mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-timer @bors @notriddle @rustbot