Skip to content

Conversation

notriddle
Copy link
Contributor

Link classes use the abbreviation attr ...

.content span.attr, .content a.attr,
.content span.derive, .content a.derive,
.content span.macro, .content a.macro {
color: var(--macro-link-color);
}

... so why does syntax highlighting use the full word?

pre.rust .attribute {
color: var(--code-highlight-attribute-color);
}

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2022

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 31, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Link classes use the abbreviation `attr`, so why shouldn't
syntax highlighting?
@notriddle notriddle force-pushed the notriddle/attribute-css branch from 7cf95b0 to 6432bb7 Compare October 31, 2022 20:55
@GuillaumeGomez
Copy link
Member

Thanks!

@GuillaumeGomez
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 1, 2022

📌 Commit 6432bb7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#84022 (Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error)
 - rust-lang#103760 (resolve: Turn the binding from `#[macro_export]` into a proper `Import`)
 - rust-lang#103813 (rustdoc: remove unnecessary CSS `.search-results { clear: both }`)
 - rust-lang#103817 (rustdoc: rename syntax highlighting CSS class `attribute` to `attr`)
 - rust-lang#103833 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2b0ead3 into rust-lang:master Nov 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants