⬆️ rust-analyzer #103833
Merged
⬆️ rust-analyzer #103833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Don't respond with an error when requesting a shutdown while starting
…e it is being invoked for
fix: Fix standard flycheck command not being executed in the workspace it is being invoked for Fixes rust-lang/rust-analyzer#13477
…, r=flodiebold fix: Test all generic args for trait when finding matching impl Addresses rust-lang/rust-analyzer#13463 (comment) When finding matching impl for a trait method, we've been testing the unifiability of self type. However, there can be multiple impl of a trait for the same type with different generic arguments for the trait. This patch takes it into account and tests the unifiability of all type arguments for the trait (the first being the self type) thus enables rust-analyzer to find the correct impl even in such cases.
Switch to upstream `positionEncoding` Closes rust-lang#13481 This drops support for the custom extension, but that's probably fine. Draft because it's not tested yet.
feat: type inference for generic associated types This PR implements type inference for generic associated types. Basically, this PR lowers generic arguments for associated types in valid places and creates `Substitution`s for them. I focused on the inference for correct Rust programs, so there are cases where we *accidentally* manage to infer things that are actually invalid (which would then be reported by flycheck so I deem them non-fatal). See the following tests and FIXME notes on them: `gats_with_dyn`, `gats_with_impl_trait`. The added tests are rather arbitrary. Let me know if there are cases I'm missing or I should add. Closes rust-lang#9673
…hievink internal: Clarify feature policy CC rust-lang#13495
feat: Clicking the status bar item stops and starts the server
Always set up VSCode commands
…eykril Properly handle vscode workspace changes
Clean up tests and add documentation for GATs related stuff This is a follow-up PR for rust-lang#13494. - addresses rust-lang/rust-analyzer#13494 (comment) - documents the ordering constraint on `Binders` and `Substitution` (which is not really follow-up for the previous PR, but it was introduced to support GATs and I strongly feel it's worth it)
rustbot
added
the
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 1, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#84022 (Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error) - rust-lang#103760 (resolve: Turn the binding from `#[macro_export]` into a proper `Import`) - rust-lang#103813 (rustdoc: remove unnecessary CSS `.search-results { clear: both }`) - rust-lang#103817 (rustdoc: rename syntax highlighting CSS class `attribute` to `attr`) - rust-lang#103833 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost