[stable] Lower lint level for READ_ZERO_BYTE_VEC #103859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids reporting false-positives; see rust-lang/rust-clippy#9274 for details.
|
@Mark-Simulacrum: no appropriate reviewer found, use r? to override |
|
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors rollup=never p=100 |
Manishearth
approved these changes
Nov 2, 2022
|
You will probably have to run Otherwise this sgtm |
Manishearth
requested changes
Nov 2, 2022
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
commented
Nov 2, 2022
| LintId::of(redundant_pub_crate::REDUNDANT_PUB_CRATE), | ||
| LintId::of(regex::TRIVIAL_REGEX), | ||
| LintId::of(strings::STRING_LIT_AS_BYTES), | ||
| LintId::of(suspicious_operation_groupings::SUSPICIOUS_OPERATION_GROUPINGS), | ||
| LintId::of(trailing_empty_array::TRAILING_EMPTY_ARRAY), | ||
| LintId::of(trait_bounds::TRAIT_DUPLICATION_IN_BOUNDS), | ||
| LintId::of(trait_bounds::TYPE_REPETITION_IN_BOUNDS), |
There was a problem hiding this comment.
This seems right according to the content of the lint definition but obviously isn't a change I made in this PR -- is this OK?
This comment has been minimized.
This comment has been minimized.
flip1995
approved these changes
Nov 2, 2022
|
@bors r=flip1995 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7c57093 with merge e30a6fdeba4586b8bce3bd50628ac2dbc05258b2... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-bootstrap
|
@bors r=flip1995 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2022
…load, r=jyn514 Fix artifact version/channel detection for stable On stable, our artifacts are uploaded with the raw version number (e.g., 1.65.0), not the channel. This adjusts our detection logic to use the version number from src/version when we detect the stable channel. This is really only important for stable channel re-builds, I think, but those do happen from time to time. I'm backporting a similar commit in rust-lang#103859 to make that PR pass CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids reporting false-positives; see rust-lang/rust-clippy#9274 for details.
cc @rust-lang/clippy -- do we want a direct change landed on stable here? If so, please r+ this PR, otherwise we can just close it. Would appreciate confirmation this is the right change to make as well.
cc @joshtriplett -- filing due to https://rust-lang.zulipchat.com/#narrow/stream/301329-t-devtools/topic/clippy.20false.20positive