Fix artifact version/channel detection for stable #103878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jyn514 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
jyn514
approved these changes
Nov 2, 2022
This comment has been minimized.
This comment has been minimized.
On stable, our artifacts are uploaded with the raw version number (e.g., 1.65.0), not the channel. This adjusts our detection logic to use the version number from src/version when we detect the stable channel.
Mark-Simulacrum
force-pushed
the
fix-stable-ci-download
branch
from
e9c08c2
to
2949009
Compare
|
Ready for another review. |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103868 (Use `TraitEngine` (by itself) less) - rust-lang#103878 (Fix artifact version/channel detection for stable) - rust-lang#103946 (Cleanup bind_pattern args) - rust-lang#103956 (Make mir opt unused file check blessable) - rust-lang#103977 (LLVM 16: Switch to using MemoryEffects) - rust-lang#103980 (rustdoc: simplify search results CSS and DOM) - rust-lang#103984 (Refactor tcx mk_const parameters.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On stable, our artifacts are uploaded with the raw version number (e.g., 1.65.0), not the channel. This adjusts our detection logic to use the version number from src/version when we detect the stable channel.
This is really only important for stable channel re-builds, I think, but those do happen from time to time. I'm backporting a similar commit in #103859 to make that PR pass CI.