Skip to content

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 3, 2022

Part of #103874

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@chenyukang
Copy link
Member Author

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned davidtwco Nov 3, 2022
@chenyukang chenyukang changed the title Improve use of ErrorGuaranteed and code cleanup [WIP] Improve use of ErrorGuaranteed and code cleanup Nov 3, 2022
@lcnr
Copy link
Contributor

lcnr commented Nov 3, 2022

r=me on the current changes

@chenyukang chenyukang changed the title [WIP] Improve use of ErrorGuaranteed and code cleanup Improve use of ErrorGuaranteed and code cleanup Nov 3, 2022
@lcnr
Copy link
Contributor

lcnr commented Nov 3, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2022

📌 Commit c6d23bd has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2022
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#103825 (Remove let_underscore_must_use from list of uplifted lints)
 - rust-lang#103884 (Add visit_fn_ret_ty to hir intravisit)
 - rust-lang#103892 (Properly render asyncness for trait fns without default body)
 - rust-lang#103905 (rustdoc: remove redundant mobile CSS `.sidebar-elems { background }`)
 - rust-lang#103912 (Add howto for adding new targets)
 - rust-lang#103915 (Improve use of ErrorGuaranteed and code cleanup)
 - rust-lang#103930 (Move some tests from `src/test/ui` to more reasonable places)
 - rust-lang#103931 (Add note to RELEASES.md regarding issue 102754.)
 - rust-lang#103938 (rustdoc: clean up hardcoded CSS border color on search results)
 - rust-lang#103940 (rustdoc: remove no-op CSS `#main-content > .item-info { margin-top: 0 }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 61c6cdb into rust-lang:master Nov 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants