Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: clean up hardcoded CSS border color on search results #103938

Merged

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Nov 3, 2022

Hardcoded colors in rustdoc.css should usually be avoided.

Preview: http://notriddle.com/notriddle-rustdoc-demos/border-bottom-search/test_dingus/?search=test

Hardcoded colors in rustdoc.css should usually be avoided.
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 3, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Missed this one, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 3, 2022

📌 Commit f097940 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2022
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#103825 (Remove let_underscore_must_use from list of uplifted lints)
 - rust-lang#103884 (Add visit_fn_ret_ty to hir intravisit)
 - rust-lang#103892 (Properly render asyncness for trait fns without default body)
 - rust-lang#103905 (rustdoc: remove redundant mobile CSS `.sidebar-elems { background }`)
 - rust-lang#103912 (Add howto for adding new targets)
 - rust-lang#103915 (Improve use of ErrorGuaranteed and code cleanup)
 - rust-lang#103930 (Move some tests from `src/test/ui` to more reasonable places)
 - rust-lang#103931 (Add note to RELEASES.md regarding issue 102754.)
 - rust-lang#103938 (rustdoc: clean up hardcoded CSS border color on search results)
 - rust-lang#103940 (rustdoc: remove no-op CSS `#main-content > .item-info { margin-top: 0 }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f35dccb into rust-lang:master Nov 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 4, 2022
@notriddle notriddle deleted the notriddle/search-results-border-bottom branch November 4, 2022 14:59
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 5, 2022
…olor, r=notriddle

Fix search result bottom border color

It reverts a color change while keeping the improvement made in rust-lang#103938.

I think it'll need to be backported once merged too.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants