Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move browser opening logic in Builder #103920

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

pietroalbini
Copy link
Member

This allows open() to be called from other places in bootstrap (I need this for Ferrocene, as we keep our custom steps in src/bootstrap/ferrocene), and it simplifies the callers by moving the was_invoked_explicitly check into the function.

This allows open() to be called from other places in bootstrap (I need
this for Ferrocene), and it simplifies the callers by moving the
"was_invoked_explicitly" check into the function.
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

r? @jyn514

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
@jyn514
Copy link
Member

jyn514 commented Nov 3, 2022

@bors r+ rollup

@jyn514
Copy link
Member

jyn514 commented Nov 5, 2022

bors is asleep again 😩

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

📌 Commit 5e4618f has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 5, 2022
…, r=jyn514

Move browser opening logic in `Builder`

This allows `open()` to be called from other places in bootstrap (I need this for Ferrocene, as we keep our custom steps in `src/bootstrap/ferrocene`), and it simplifies the callers by moving the `was_invoked_explicitly` check into the function.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2022
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#101702 (rustdoc: add hash to filename of toolchain files)
 - rust-lang#103920 (Move browser opening logic in `Builder`)
 - rust-lang#103927 (Do not make typo suggestions when suggesting pattern matching)
 - rust-lang#103972 (Remove an option and choose a behaviour-preserving default instead.)
 - rust-lang#103988 (Fix search result bottom border color)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 305cb71 into rust-lang:master Nov 5, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 5, 2022
@pietroalbini pietroalbini deleted the pa-maybe-open-in-browser branch November 7, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants