Move browser opening logic in Builder
#103920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows open() to be called from other places in bootstrap (I need this for Ferrocene), and it simplifies the callers by moving the "was_invoked_explicitly" check into the function.
|
r? @jyn514 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
jyn514
reviewed
Nov 3, 2022
|
@bors r+ rollup |
|
bors is asleep again 😩 @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 5, 2022
…, r=jyn514 Move browser opening logic in `Builder` This allows `open()` to be called from other places in bootstrap (I need this for Ferrocene, as we keep our custom steps in `src/bootstrap/ferrocene`), and it simplifies the callers by moving the `was_invoked_explicitly` check into the function.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2022
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#101702 (rustdoc: add hash to filename of toolchain files) - rust-lang#103920 (Move browser opening logic in `Builder`) - rust-lang#103927 (Do not make typo suggestions when suggesting pattern matching) - rust-lang#103972 (Remove an option and choose a behaviour-preserving default instead.) - rust-lang#103988 (Fix search result bottom border color) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
open()to be called from other places in bootstrap (I need this for Ferrocene, as we keep our custom steps insrc/bootstrap/ferrocene), and it simplifies the callers by moving thewas_invoked_explicitlycheck into the function.