Skip to content

Do not make typo suggestions when suggesting pattern matching #103927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2022
Merged

Do not make typo suggestions when suggesting pattern matching #103927

merged 1 commit into from
Nov 5, 2022

Conversation

fee1-dead
Copy link
Member

Fixes #103909.

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2022
@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2022
@fee1-dead fee1-dead force-pushed the E0425-no-typo-when-pattern-matching branch from db9fbda to b1994ce Compare November 5, 2022 15:33
@cjgillot
Copy link
Contributor

cjgillot commented Nov 5, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

📌 Commit b1994ce has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2022
@bors
Auto merge of rust-lang#104017 - matthiaskrgr:rollup-k8i0j9m, r=matth…
371100b 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#101702 (rustdoc: add hash to filename of toolchain files)
 - rust-lang#103920 (Move browser opening logic in `Builder`)
 - rust-lang#103927 (Do not make typo suggestions when suggesting pattern matching)
 - rust-lang#103972 (Remove an option and choose a behaviour-preserving default instead.)
 - rust-lang#103988 (Fix search result bottom border color)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 51287f2 into rust-lang:master Nov 5, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 5, 2022
@fee1-dead fee1-dead deleted the E0425-no-typo-when-pattern-matching branch July 19, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Remove unhelpful diagnostic when we suggesting for if-let
4 participants
@fee1-dead @rustbot @cjgillot @bors