Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap bundled static libraries into object files #104091

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Wrap bundled static libraries into object files #104091

merged 1 commit into from
Nov 15, 2022

Conversation

belovdv
Copy link
Contributor

@belovdv belovdv commented Nov 7, 2022

Fixes #103044 (not sure, couldn't test locally)

Bundled static libraries should be wrapped into object files as it's done for metadata file.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@belovdv
Copy link
Contributor Author

belovdv commented Nov 7, 2022

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2022
@belovdv
Copy link
Contributor Author

belovdv commented Nov 7, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2022
petrochenkov
petrochenkov reviewed Nov 9, 2022
View reviewed changes
compiler/rustc_codegen_ssa/src/back/metadata.rs Outdated Show resolved Hide resolved
compiler/rustc_metadata/src/fs.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/archive.rs Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022
@belovdv belovdv mentioned this pull request Nov 13, 2022
Closed
@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Nov 14, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2022

📌 Commit e16c778 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2022
@ehuss
Copy link
Contributor

ehuss commented Nov 14, 2022

@bors p=100

CI has been migrated to macos-12, which is now failing.

@bors
Copy link
Contributor

bors commented Nov 15, 2022

⌛ Testing commit e16c778 with merge dedfb9c...

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 15, 2022
Merged
@bors
Copy link
Contributor

bors commented Nov 15, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing dedfb9c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2022
@bors bors merged commit dedfb9c into rust-lang:master Nov 15, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 15, 2022
This was referenced Nov 15, 2022
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dedfb9c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.0% [4.0%, 4.0%] 1
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 4.0% [4.0%, 4.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.7% [4.7%, 4.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.7% [4.7%, 4.7%] 1

This was referenced Nov 18, 2022
Merged
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Nov 20, 2022
@Mark-Simulacrum
Ignore test to fix macOS CI
db0c4e5 
The proper fix for this is
rust-lang#104091, but we're avoiding a
backport for it since this is just failing for an unstable feature.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#104091 - BelovDV:issue-103044, r=petrochenkov
c245769 
Wrap bundled static libraries into object files

Fixes rust-lang#103044 (not sure, couldn't test locally)

Bundled static libraries should be wrapped into object files as it's done for metadata file.

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

rlib-format-packed-bundled-libs test failures on Xcode 14
8 participants
@belovdv @rust-log-analyzer @rustbot @petrochenkov @bors @ehuss @rust-timer @bjorn3