Skip to content

Issue error when -C link-self-contained option is used on unsupported platforms #104137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

Issue error when -C link-self-contained option is used on unsupported platforms #104137

merged 1 commit into from
Nov 16, 2022

Conversation

StackDoubleFlow
Copy link
Contributor

The documentation was also updated to reflect this.

I'm assuming the supported platforms are the same as initially written in RELEASES.md.

Fixes #103576

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@petrochenkov petrochenkov self-assigned this Nov 8, 2022
@compiler-errors
Copy link
Member

r? @petrochenkov

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2022

Could not assign reviewer from: petrochenkov.
User(s) petrochenkov are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

@compiler-errors compiler-errors removed their assignment Nov 8, 2022
petrochenkov
petrochenkov reviewed Nov 10, 2022
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

@petrochenkov
Copy link
Contributor

Thanks!
r=me after squashing commits.
@rustbot author

@StackDoubleFlow
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2022
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 11, 2022

📌 Commit f6d7f08 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 11, 2022
@Manishearth
Rollup merge of rust-lang#104137 - StackDoubleFlow:err-lsc-unsupporte…
86fdaaa 
…d, r=petrochenkov

Issue error when -C link-self-contained option is used on unsupported platforms

The documentation was also updated to reflect this.

I'm assuming the supported platforms are the same as initially written in [RELEASES.md](https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler-17).

Fixes rust-lang#103576
@Manishearth Manishearth mentioned this pull request Nov 11, 2022
Closed
@rustbot rustbot assigned bjorn3 and unassigned petrochenkov Nov 14, 2022
@petrochenkov petrochenkov removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 14, 2022
@bjorn3
Copy link
Member

bjorn3 commented Nov 14, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 14, 2022

📌 Commit f280fd05cf09686677a8fe388bee51c0b837a984 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022
@bors
Copy link
Collaborator

bors commented Nov 15, 2022

☔ The latest upstream changes (presumably #104091) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2022
@StackDoubleFlow
Issue error when -C link-self-contained option is used on unsupport…
0b6dce4 
…ed platforms

Document supported targets for `-C link-self-contained`

Move `LinkSelfContainedDefault::True` from wasm_base to wasm32_wasi
@bjorn3
Copy link
Member

bjorn3 commented Nov 15, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 15, 2022

📌 Commit 0b6dce4 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2022
@matthiaskrgr
Rollup merge of rust-lang#104137 - StackDoubleFlow:err-lsc-unsupporte…
abd4e2d 
…d, r=bjorn3

Issue error when -C link-self-contained option is used on unsupported platforms

The documentation was also updated to reflect this.

I'm assuming the supported platforms are the same as initially written in [RELEASES.md](https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler-17).

Fixes rust-lang#103576
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2022
@bors
Auto merge of rust-lang#104492 - matthiaskrgr:rollup-3xyjynz, r=matth…
e69336e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103750 (Fix some misleading target feature aliases)
 - rust-lang#104137 (Issue error when -C link-self-contained option is used on unsupported platforms)
 - rust-lang#104317 (cleanup and dedupe CTFE and Miri error reporting)
 - rust-lang#104335 (Only do parser recovery on retried macro matching)
 - rust-lang#104394 (various cleanups to try to reduce the use of spans inside method resolution)
 - rust-lang#104459 (rustdoc: remove unused JS IIFE from main.js)
 - rust-lang#104462 (rustdoc: remove pointless CSS `.rightside { padding-right: 2px }`)
 - rust-lang#104466 (rustdoc: remove no-op CSS `#crate-search-div { display: inline-block }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fbcd751 into rust-lang:master Nov 16, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 16, 2022
@StackDoubleFlow StackDoubleFlow deleted the err-lsc-unsupported branch December 24, 2022 17:05
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#104137 - StackDoubleFlow:err-lsc-unsupporte…
a53ef74 
…d, r=bjorn3

Issue error when -C link-self-contained option is used on unsupported platforms

The documentation was also updated to reflect this.

I'm assuming the supported platforms are the same as initially written in [RELEASES.md](https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler-17).

Fixes rust-lang#103576
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#104492 - matthiaskrgr:rollup-3xyjynz, r=matth…
c1d6ff4 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103750 (Fix some misleading target feature aliases)
 - rust-lang#104137 (Issue error when -C link-self-contained option is used on unsupported platforms)
 - rust-lang#104317 (cleanup and dedupe CTFE and Miri error reporting)
 - rust-lang#104335 (Only do parser recovery on retried macro matching)
 - rust-lang#104394 (various cleanups to try to reduce the use of spans inside method resolution)
 - rust-lang#104459 (rustdoc: remove unused JS IIFE from main.js)
 - rust-lang#104462 (rustdoc: remove pointless CSS `.rightside { padding-right: 2px }`)
 - rust-lang#104466 (rustdoc: remove no-op CSS `#crate-search-div { display: inline-block }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@cuviper cuviper mentioned this pull request Mar 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@bjorn3 bjorn3 bjorn3 left review comments

+1 more reviewer

@pnkfelix pnkfelix pnkfelix left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@bjorn3 bjorn3

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

-C self-contained=yes creates programs that crash on startup (on linux-gnu targets)
7 participants
@StackDoubleFlow @rustbot @compiler-errors @petrochenkov @bors @bjorn3 @pnkfelix