Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: use checkbox instead of switch for settings toggles #104267

Merged
merged 2 commits into from
Nov 12, 2022
Merged

rustdoc: use checkbox instead of switch for settings toggles #104267

merged 2 commits into from
Nov 12, 2022

Commits on Nov 11, 2022

  1. rustdoc: use checkbox instead of switch for settings toggles 

    The switch is designed to give the application a "physical" feel, but
nothing else in here really followed through. They didn't support the
"flick" gesture that real iOS switches support, and the radio
buttons that were also used in Rustdoc Settings were a more "classic"
form element anyway.

Also, while "switches" are the exclusive toggle design on iOS (since
[Apple HIG] reserves checkboxes for Mac only), the [Google Material]
guidelines say that lists of switches are bad, and you should just use
check boxes.

[Apple HIG]: https://developer.apple.com/design/human-interface-guidelines/components/selection-and-input/toggles
[Google Material]: https://m3.material.io/components/checkbox/guidelines#6902f23d-ceba-4b19-ae3b-b78b9b01d185
    @notriddle
    notriddle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    0f3ae62 View commit details
    Browse the repository at this point in the history

  2. rustdoc: add test cases for checkbox toggles

    @notriddle
    notriddle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    269dad2 View commit details
    Browse the repository at this point in the history